-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-3996]: Shade Jetty in Spark deliverables #4285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This patch piggy-back's on @vanzin's work to simplify the Guava shading, and adds Jetty as a shaded library in Spark. Other than adding Jetty, it consilidates the <artifactSet>'s into the root pom. I found it was a bit easier to follow that way, since you don't need to look into child pom's to find out specific artifact sets included in shading.
|
Test build #26367 has started for PR 4285 at commit
|
|
LGTM. Just looked at the last commit, though, assumed the others are the same. |
|
Test build #26367 has finished for PR 4285 at commit
|
|
Test FAILed. |
|
Jenkins, test this please. |
|
Test build #26415 has started for PR 4285 at commit
|
|
Test build #26415 has finished for PR 4285 at commit
|
|
Test PASSed. |
|
Okay - let's try this for take 2. |
(v2 of this patch with a fix that was only relevant for the maven build).
This patch piggy-back's on @vanzin's work to simplify the Guava shading,
and adds Jetty as a shaded library in Spark. Other than adding Jetty,
it consilidates the 's into the root pom. I found it was
a bit easier to follow that way, since you don't need to look into
child pom's to find out specific artifact sets included in shading.