-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-5424][MLLIB] make the new ALS impl take generic ID types #4281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Test build #26350 has started for PR 4281 at commit
|
|
Test build #26352 has started for PR 4281 at commit
|
|
Test build #26352 has finished for PR 4281 at commit
|
|
Test PASSed. |
|
Test build #26350 has finished for PR 4281 at commit
|
|
Test PASSed. |
|
Compared object allocation and performance against master. Having generic types didn't downgrade performance. I've merged this into master. |
This PR makes the ALS implementation take generic ID types, e.g., Long and String, and expose it as a developer API.
TODO:
@srowen You may like this change:) I hit a Scala compiler bug with specialization. It compiles now but users and items must have the same type. I'm going to check whether specialization really works.