Skip to content

Conversation

@mengxr
Copy link
Contributor

@mengxr mengxr commented Jan 30, 2015

This PR makes the ALS implementation take generic ID types, e.g., Long and String, and expose it as a developer API.

TODO:

  • make sure that specialization works (validated in profiler)

@srowen You may like this change:) I hit a Scala compiler bug with specialization. It compiles now but users and items must have the same type. I'm going to check whether specialization really works.

@SparkQA
Copy link

SparkQA commented Jan 30, 2015

Test build #26350 has started for PR 4281 at commit 135f741.

  • This patch does not merge cleanly.

@SparkQA
Copy link

SparkQA commented Jan 30, 2015

Test build #26352 has started for PR 4281 at commit 96072c3.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 30, 2015

Test build #26352 has finished for PR 4281 at commit 96072c3.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26352/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 30, 2015

Test build #26350 has finished for PR 4281 at commit 135f741.

  • This patch passes all tests.
  • This patch does not merge cleanly.
  • This patch adds the following public classes (experimental):
    • case class Rating[@specialized(Int, Long) ID](user: ID, item: ID, rating: Float)

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26350/
Test PASSed.

@asfgit asfgit closed this in 4a17122 Feb 1, 2015
@mengxr
Copy link
Contributor Author

mengxr commented Feb 1, 2015

Compared object allocation and performance against master. Having generic types didn't downgrade performance. I've merged this into master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants