[SPARK-5672][Web UI] Don't return `ERROR 500` when have missing args #4239

catap · 2015-01-28T07:34:43Z

Spark web UI return HTTP ERROR 500 when GET arguments is missing.

AmplabJenkins · 2015-01-28T07:37:09Z

Can one of the admins verify this patch?

srowen · 2015-01-28T09:02:07Z

I agree that 5xx means server error, and is not an appropriate response. But assuming a value of -1 doesn't seem like a great solution -- how about returning 400 Bad Request? (PS this needs a JIRA if it proceeds)

catap · 2015-01-28T11:00:20Z

Ok, the patch was updated.

srowen · 2015-01-28T11:02:53Z

core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala

Nit: paramater -> parameter

andrewor14 · 2015-01-28T20:55:01Z

ok to test

AmplabJenkins · 2015-01-28T21:12:18Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26247/
Test FAILed.

andrewor14 · 2015-01-30T23:05:02Z

retest this please

SparkQA · 2015-01-30T23:07:39Z

Test build #26436 has started for PR 4239 at commit b6066e3.

This patch merges cleanly.

SparkQA · 2015-01-31T00:03:15Z

Test build #26436 has finished for PR 4239 at commit b6066e3.

This patch fails Spark unit tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-01-31T00:03:18Z

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26436/
Test FAILed.

SparkQA · 2015-02-03T06:47:29Z

Test build #26623 has started for PR 4239 at commit ed4154d.

This patch merges cleanly.

SparkQA · 2015-02-03T07:54:50Z

Test build #26623 has finished for PR 4239 at commit ed4154d.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-03T07:54:54Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26623/
Test PASSed.

srowen · 2015-02-07T15:42:41Z

core/src/main/scala/org/apache/spark/ui/exec/ExecutorThreadDumpPage.scala

These imports were correct where they were I believe.

I use Intellij IDEA and this was changed imports.

SparkQA · 2015-02-07T16:42:55Z

Test build #27004 has started for PR 4239 at commit 3ba74ba.

This patch merges cleanly.

SparkQA · 2015-02-07T17:57:31Z

Test build #27004 has finished for PR 4239 at commit 3ba74ba.

This patch passes all tests.
This patch merges cleanly.
This patch adds the following public classes (experimental):
- case class MasterStateResponse(
- class LocalSparkCluster(
- * (4) the main class for the child
- case class BoundPortsResponse(actorPort: Int, webUIPort: Int, restPort: Option[Int])
- throw new SubmitRestMissingFieldException("Main class is missing.")

AmplabJenkins · 2015-02-07T17:57:35Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27004/
Test PASSed.

srowen · 2015-02-07T21:15:18Z

It's looking good to me but can you make a JIRA (https://issues.apache.org/jira/browse/SPARK/) and put it into the title like SPARK-xxxx [WEB UI] ... ?

Spark web UI return `HTTP ERROR 500` when GET arguments is missing. Changed it to return a `HTTP ERROR 400`

SparkQA · 2015-02-08T01:58:00Z

Test build #27020 has started for PR 4239 at commit 520e180.

This patch merges cleanly.

SparkQA · 2015-02-08T03:10:44Z

Test build #27020 has finished for PR 4239 at commit 520e180.

This patch passes all tests.
This patch merges cleanly.
This patch adds no public classes.

AmplabJenkins · 2015-02-08T03:10:48Z

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/27020/
Test PASSed.

Spark web UI return `HTTP ERROR 500` when GET arguments is missing. Author: Kirill A. Korinskiy <[email protected]> Closes #4239 from catap/ui_500 and squashes the following commits: 520e180 [Kirill A. Korinskiy] [SPARK-5672][Web UI] Return `HTTP ERROR 400` when have missing args (cherry picked from commit 23a99da) Signed-off-by: Sean Owen <[email protected]>

catap force-pushed the ui_500 branch from 4faba92 to c164f99 Compare January 28, 2015 10:59

srowen reviewed Jan 28, 2015
View reviewed changes

core/src/main/scala/org/apache/spark/ui/jobs/JobPage.scala Outdated

Copy link

Member

srowen Jan 28, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: paramater -> parameter

catap force-pushed the ui_500 branch 2 times, most recently from ab826b4 to b6066e3 Compare January 28, 2015 16:58

catap force-pushed the ui_500 branch from b6066e3 to ed4154d Compare February 3, 2015 06:44

srowen reviewed Feb 7, 2015
View reviewed changes

catap force-pushed the ui_500 branch from ed4154d to 3ba74ba Compare February 7, 2015 16:37

catap force-pushed the ui_500 branch from 3ba74ba to 77b9c63 Compare February 8, 2015 01:54

[SPARK-5672][Web UI] Return HTTP ERROR 400 when have missing args

520e180

Spark web UI return `HTTP ERROR 500` when GET arguments is missing. Changed it to return a `HTTP ERROR 400`

catap force-pushed the ui_500 branch from 77b9c63 to 520e180 Compare February 8, 2015 01:56

catap changed the title ~~Don't return ERROR 500 when have missing args~~ [SPARK-5672][Web UI] Don't return ERROR 500 when have missing args Feb 8, 2015

asfgit closed this in 23a99da Feb 8, 2015

[SPARK-5672][Web UI] Don't return ERROR 500 when have missing args #4239

[SPARK-5672][Web UI] Don't return ERROR 500 when have missing args #4239

Uh oh!

Conversation

catap commented Jan 28, 2015

Uh oh!

AmplabJenkins commented Jan 28, 2015

Uh oh!

srowen commented Jan 28, 2015

Uh oh!

catap commented Jan 28, 2015

Uh oh!

srowen Jan 28, 2015

Choose a reason for hiding this comment

Uh oh!

andrewor14 commented Jan 28, 2015

Uh oh!

AmplabJenkins commented Jan 28, 2015

Uh oh!

andrewor14 commented Jan 30, 2015

Uh oh!

SparkQA commented Jan 30, 2015

Uh oh!

SparkQA commented Jan 31, 2015

Uh oh!

AmplabJenkins commented Jan 31, 2015

Uh oh!

SparkQA commented Feb 3, 2015

Uh oh!

SparkQA commented Feb 3, 2015

Uh oh!

AmplabJenkins commented Feb 3, 2015

Uh oh!

srowen Feb 7, 2015

Choose a reason for hiding this comment

Uh oh!

catap Feb 7, 2015

Choose a reason for hiding this comment

Uh oh!

SparkQA commented Feb 7, 2015

Uh oh!

SparkQA commented Feb 7, 2015

Uh oh!

AmplabJenkins commented Feb 7, 2015

Uh oh!

srowen commented Feb 7, 2015

Uh oh!

SparkQA commented Feb 8, 2015

Uh oh!

SparkQA commented Feb 8, 2015

Uh oh!

AmplabJenkins commented Feb 8, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[SPARK-5672][Web UI] Don't return `ERROR 500` when have missing args #4239

[SPARK-5672][Web UI] Don't return `ERROR 500` when have missing args #4239