Skip to content

[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext #4227

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext #4227

wants to merge 1 commit into from

Conversation

@OopsOutOfMemory
Copy link
Contributor

@OopsOutOfMemory OopsOutOfMemory commented Jan 27, 2015

Hi, @rxin @marmbrus
I considered your suggestion (in #4127) and now re-write it. This is now up-to-date.
Could u please review it ?

@OopsOutOfMemory OopsOutOfMemory mentioned this pull request Jan 27, 2015
Closed
@AmplabJenkins
Copy link

AmplabJenkins commented Jan 27, 2015

Can one of the admins verify this patch?

@rxin rxin mentioned this pull request Jan 28, 2015
Closed
@rxin
Copy link
Contributor

rxin commented Jan 28, 2015

Thanks for submitting the new version. Are these two PRs working on the same thing? #4207 Would be great if you two can chime in on each other's PR.

@OopsOutOfMemory
Copy link
Contributor Author

OopsOutOfMemory commented Jan 28, 2015

yeah, @rxin, would you like to talk with @marmbrus for what we'd like to show in describe extended table in SQLContext and then file a JIRA issues? So that we can do it separately but not in this PR ?

@rxin
Copy link
Contributor

rxin commented Feb 4, 2015

@marmbrus this looks good to me. Any more comments?

@OopsOutOfMemory would be great to bring this up to date with master. Thanks.

@OopsOutOfMemory
Copy link
Contributor Author

OopsOutOfMemory commented Feb 4, 2015

May AmplabJenkins test this please ?

@rxin
Copy link
Contributor

rxin commented Feb 4, 2015

Jenkins, test this please.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26743 has started for PR 4227 at commit a3061a5.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 4, 2015

Test build #26743 has finished for PR 4227 at commit a3061a5.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 4, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26743/
Test PASSed.

rxin
rxin reviewed Feb 5, 2015
View reviewed changes
sql/catalyst/src/main/scala/org/apache/spark/sql/types/dataTypes.scala Outdated
Copy link
Contributor

@rxin rxin Feb 5, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you rename this simpleString?

@rxin
Copy link
Contributor

rxin commented Feb 5, 2015

I'd like to merge this into 1.3.0. Can you address the two comments I have and make sure it still works with other changes?

btw does this one conflict with your other change? https://github.com/apache/spark/pull/4249/files

@OopsOutOfMemory
Copy link
Contributor Author

OopsOutOfMemory commented Feb 5, 2015

Hi, @rxin Thanks for the advice.
I refined the code according to your advice now I think it's ready to go.

yeah, this PR is a little conflict with https://github.com/apache/spark/pull/4249/files. They all modified logical DescribeCommand. But I think it's not a big deal. This two PRs (this and #4249). No matter which one will be merged first, I'll bring the other one up-to-date quickly. And I don't want to resolve the two issues in One PR which make issues untraceable.

@rxin
Copy link
Contributor

rxin commented Feb 5, 2015

Jenkins, retest this please.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26855 has started for PR 4227 at commit 053826f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Feb 5, 2015

Test build #26855 has finished for PR 4227 at commit 053826f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Feb 5, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26855/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Feb 5, 2015

Thanks. Merging now.

asfgit pushed a commit that referenced this pull request Feb 5, 2015
@OopsOutOfMemory @rxin
[SPARK-5135][SQL] Add support for describe table to DDL in SQLContext
55cebcf 
Hi, rxin marmbrus
I considered your suggestion (in #4127) and now re-write it. This is now up-to-date.
Could u please review it ?

Author: OopsOutOfMemory <[email protected]>

Closes #4227 from OopsOutOfMemory/describe and squashes the following commits:

053826f [OopsOutOfMemory] describe

(cherry picked from commit 4d8d070)
Signed-off-by: Reynold Xin <[email protected]>
@asfgit asfgit closed this in 4d8d070 Feb 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@OopsOutOfMemory @AmplabJenkins @rxin @SparkQA