[SPARK-44079][SQL] Fix ArrayIndexOutOfBoundsException when parse array as struct using PERMISSIVE mode with corrupt record
#41662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
cc @MaxGekk |
…ray as struct using PERMISSIVE mode with corrupt record
Hisoka-X
force-pushed
the
SPARK-44079_array_as_structs_corrput_record
branch
from
15a061c to
32d8b87
Compare
MaxGekk
reviewed
Jun 19, 2023
Member
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
@Hisoka-X Thank you for the ping. Could you enable GAs in your fork: https://github.com/apache/spark/pull/41662/checks?check_run_id=14375296234
Member
Author
|
Hi @MaxGekk ,please check https://github.com/Hisoka-X/spark/actions/runs/5312527795 temporarily. The CI already started, something wrong with github after I forch push code. I will fix this after all CI done. |
Member
Author
|
@MaxGekk Hi, CI passed. Please help me to review. Thanks! |
MaxGekk
reviewed
Jun 27, 2023
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/BadRecordException.scala
Show resolved
Hide resolved
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/csv/UnivocityParser.scala
Outdated
Show resolved
Hide resolved
Hisoka-X
force-pushed
the
SPARK-44079_array_as_structs_corrput_record
branch
from
66b4e99 to
9a3a8c2
Compare
MaxGekk
requested changes
Jun 28, 2023
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/json/JsonSuite.scala
Outdated
Show resolved
Hide resolved
Member
|
LGTM in general. cc @HyukjinKwon |
…rces/json/JsonSuite.scala Co-authored-by: Maxim Gekk <[email protected]>
MaxGekk
approved these changes
Jun 29, 2023
Member
|
+1, LGTM. Merging to master. |
Member
Author
|
Thanks @MaxGekk |
Member
|
@Hisoka-X Does 3.4 has the issue? If so, please, open a PR with the backport. |
Hisoka-X
added a commit
to Hisoka-X/spark
that referenced
this pull request
Jun 29, 2023
…ray as struct using PERMISSIVE mode with corrupt record
### What changes were proposed in this pull request?
When use PERMISSIVE mode to parse json array as structs with `_corrupt_record`. The error will be reported.
```scala
val data = """[{"a": "incorrect", "b": "correct"}, {"a": "incorrect", "b": "correct"}]"""
val schema = new StructType(Array(StructField("a", IntegerType),
StructField("b", StringType), StructField("_corrupt_record", StringType)))
spark.read.option("mode", "PERMISSIVE").option("multiline", "true").schema(schema)
.json(Seq(data).toDS()).show()
// error
org.apache.spark.SparkException: Job aborted due to stage failure: Task 4 in stage 2.0 failed 1 times, most recent failure: Lost task 4.0 in stage 2.0 (TID 9) (charlottesmbp2.home executor driver): java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
at org.apache.spark.sql.catalyst.expressions.GenericInternalRow.genericGet(rows.scala:201)
at org.apache.spark.sql.catalyst.expressions.BaseGenericInternalRow.getAs(rows.scala:35)
at org.apache.spark.sql.catalyst.expressions.BaseGenericInternalRow.get(rows.scala:37)
at org.apache.spark.sql.catalyst.expressions.BaseGenericInternalRow.get$(rows.scala:37)
at org.apache.spark.sql.catalyst.expressions.GenericInternalRow.get(rows.scala:195)
```
The `JacksonParser` wrap row list as a new `InternalRow`. So `FailureSafeParser` can't parse it normally when `_corrupt_record` is defined.
This PR to make sure `BadRecordException` can cover row list parsed by a string record. Then the `FailureSafeParser` can handle row list one by one.
### Why are the changes needed?
Fix the bug when parse array as struct using PERMISSIVE mode with corrupt record
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
add new test.
Closes apache#41662 from Hisoka-X/SPARK-44079_array_as_structs_corrput_record.
Authored-by: Jia Fan <[email protected]>
Signed-off-by: Max Gekk <[email protected]>
(cherry picked from commit 70f3427)
MaxGekk
pushed a commit
that referenced
this pull request
Jun 29, 2023
…se array as struct using PERMISSIVE mode with corrupt record ### What changes were proposed in this pull request? cherry pick #41662 , fix parse array as struct bug on branch 3.4 ### Why are the changes needed? Fix the bug when parse array as struct using PERMISSIVE mode with corrupt record ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. Closes #41784 from Hisoka-X/SPARK-44079_3.4_cherry_pick. Authored-by: Jia Fan <[email protected]> Signed-off-by: Max Gekk <[email protected]>
viirya
pushed a commit
to viirya/spark-1
that referenced
this pull request
Oct 19, 2023
…se array as struct using PERMISSIVE mode with corrupt record ### What changes were proposed in this pull request? cherry pick apache#41662 , fix parse array as struct bug on branch 3.4 ### Why are the changes needed? Fix the bug when parse array as struct using PERMISSIVE mode with corrupt record ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? add new test. Closes apache#41784 from Hisoka-X/SPARK-44079_3.4_cherry_pick. Authored-by: Jia Fan <[email protected]> Signed-off-by: Max Gekk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
When use PERMISSIVE mode to parse json array as structs with
_corrupt_record. The error will be reported.The
JacksonParserwrap row list as a newInternalRow. SoFailureSafeParsercan't parse it normally when_corrupt_recordis defined.This PR to make sure
BadRecordExceptioncan cover row list parsed by a string record. Then theFailureSafeParsercan handle row list one by one.Why are the changes needed?
Fix the bug when parse array as struct using PERMISSIVE mode with corrupt record
Does this PR introduce any user-facing change?
No
How was this patch tested?
add new test.