[SPARK-43914][SQL] Assign names to the error class _LEGACY_ERROR_TEMP_[2433-2437] #41476
Conversation
There was a problem hiding this comment.
Can you trigger this errors from user space? Could you add some tests, please.
There was a problem hiding this comment.
@MaxGekk I created test cases use SimpleAnalyzer.checkAnalysis directly.
There was a problem hiding this comment.
I see but if you cannot trigger the error from user space, we should convert the error to an internal one.
There was a problem hiding this comment.
@beliefer Could you try to trigger it by from SQL.
We can't trigger it by SQL. Let me convert it to internal error.
There was a problem hiding this comment.
cc @cloud-fan Just to double check that the errors are internal.
|
ping @MaxGekk |
|
ping @MaxGekk The GA failure is unrelate to this PR. |
There was a problem hiding this comment.
Internal errors have their own error class, could you use checkError(), please.
There was a problem hiding this comment.
cc @cloud-fan Just to double check that the errors are internal.
There was a problem hiding this comment.
is this really internal? does the analyzer split select explode(...), explode(...) ... into two Projects?
There was a problem hiding this comment.
Let me have a try.
|
@beliefer Could you resolve conflicts, please. |
|
ping @MaxGekk Rebased. |
MaxGekk
left a comment
MaxGekk
left a comment
There was a problem hiding this comment.
@cloud-fan Are you ok with the changes?
|
+1, LGTM. Merging to master. |
|
@MaxGekk @cloud-fan Thank you for all. |
3 participants
What changes were proposed in this pull request?
The pr aims to assign names to the error class LEGACY_ERROR_TEMP[2433-2437].
Why are the changes needed?
Improve the error framework.
Does this PR introduce any user-facing change?
'No'.
How was this patch tested?
Exists test cases updated.