Skip to content

Conversation

@tpanningnextcen
Copy link
Contributor

Output an error message if the thrift server is started in cluster mode.

Output an error message if the thrift server is started in cluster mode.
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@andrewor14
Copy link
Contributor

@liancheng

@andrewor14
Copy link
Contributor

ok to test

@SparkQA
Copy link

SparkQA commented Jan 28, 2015

Test build #26249 has started for PR 4137 at commit f5c0509.

  • This patch merges cleanly.

@liancheng
Copy link
Contributor

@andrewor14 Yes, currently the Thrift server doesn't support YARN cluster mode. I'm trying to deliver a fix for this before 1.3.0 code freeze. I think it's OK to have this PR before I get it done.

@andrewor14
Copy link
Contributor

This is also true for standalone cluster mode right, not just YARN cluster mode?

@SparkQA
Copy link

SparkQA commented Jan 28, 2015

Test build #26249 has finished for PR 4137 at commit f5c0509.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/26249/
Test PASSed.

@liancheng
Copy link
Contributor

@andrewor14 Per our offline discuss, it still requires some minor work to make the Thrift server support standalone cluster mode (mainly related to the spark-internal argument). Currently, at least we don't want to add it in 1.3.0 yet. So this PR LGTM.

@tpanningnextcen Thanks for working on this!

@andrewor14
Copy link
Contributor

Yup LGTM. I will merge this into master shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants