Skip to content

[SPARK-43576][CORE] Remove unused declarations from Core module #41218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-43576][CORE] Remove unused declarations from Core module #41218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d28825
[SPARK-43576][CORE] Remove unused declarations from Core module
panbingkun May 18, 2023
206f506
[SPARK-43576][CORE] Remove unused declarations from Core module
panbingkun May 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion core/src/main/resources/org/apache/spark/ui/static/executorspage.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,6 @@ function totalDurationAlpha(totalGCTime, totalDuration) {
(Math.min(totalGCTime / totalDuration + 0.5, 1)) : 1;
}

// When GCTimePercent is edited change ToolTips.TASK_TIME to match
Copy link
Member

@MaxGekk MaxGekk May 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, why do you propose to remove this?

Copy link
Contributor Author

@panbingkun panbingkun May 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ToolTips.TASK_TIME - Shaded red when garbage collection (GC) time is over 10% of task time

So I think it needs to be removed; Meanwhile, I did not find any usage in the spark code base using the following command: find . -name "*" -type file -print0 | xargs -0 grep "TASK_TIME"

var GCTimePercent = 0.1;

function totalDurationStyle(totalGCTime, totalDuration) {
Expand Down
1 change: 0 additions & 1 deletion core/src/main/scala/org/apache/spark/deploy/history/ApplicationCache.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,6 @@ private[history] class ApplicationCacheCheckFilter(
val httpRequest = request.asInstanceOf[HttpServletRequest]
val httpResponse = response.asInstanceOf[HttpServletResponse]
val requestURI = httpRequest.getRequestURI
val operation = httpRequest.getMethod

// if the request is for an attempt, check to see if it is in need of delete/refresh
// and have the cache update the UI if so
Expand Down
3 changes: 0 additions & 3 deletions core/src/main/scala/org/apache/spark/rdd/HadoopRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,9 +404,6 @@ private[spark] object HadoopRDD extends Logging {
*/
val CONFIGURATION_INSTANTIATION_LOCK = new Object()

/** Update the input bytes read metric each time this number of records has been read */
val RECORDS_BETWEEN_BYTES_READ_METRIC_UPDATES = 256

/**
* The three methods below are helpers for accessing the local map, a property of the SparkEnv of
* the local process.
Expand Down
5 changes: 0 additions & 5 deletions core/src/main/scala/org/apache/spark/ui/JettyUtils.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -590,11 +590,6 @@ private class ProxyRedirectHandler(_proxyUri: String) extends HandlerWrapper {
override def sendRedirect(location: String): Unit = {
val newTarget = if (location != null) {
val target = new URI(location)
val path = if (target.getPath().startsWith("/")) {
target.getPath()
} else {
req.getRequestURI().stripSuffix("/") + "/" + target.getPath()
}
// The target path should already be encoded, so don't re-encode it, just the
// proxy address part.
val proxyBase = UIUtils.uiRoot(req)
Expand Down
7 changes: 0 additions & 7 deletions core/src/main/scala/org/apache/spark/ui/ToolTips.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,6 @@ private[spark] object ToolTips {

val OUTPUT = "Bytes written to Hadoop."

val STORAGE_MEMORY =
"Memory used / total available memory for storage of data " +
"like RDD partitions cached in memory. "

val SHUFFLE_WRITE =
"Bytes and records written to disk in order to be read by a shuffle in a future stage."

Expand Down Expand Up @@ -88,9 +84,6 @@ private[spark] object ToolTips {
also create multiple RDDs internally. Cached RDDs are shown in green.
"""

val TASK_TIME =
"Shaded red when garbage collection (GC) time is over 10% of task time"

val APPLICATION_EXECUTOR_LIMIT =
"""Maximum number of executors that this application will use. This limit is finite only when
dynamic allocation is enabled. The number of granted executors may exceed the limit
Expand Down