Skip to content

[SQL] [Minor] Remove deprecated parquet tests #4116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SQL] [Minor] Remove deprecated parquet tests #4116

wants to merge 1 commit into from

Conversation

@liancheng
Copy link
Contributor

@liancheng liancheng commented Jan 20, 2015

This PR removes the deprecated ParquetQuerySuite, renamed ParquetQuerySuite2 to ParquetQuerySuite, and refactored changes introduced in #4115 to ParquetFilterSuite . It is a follow-up of #3644.

Notice that test cases in the old ParquetQuerySuite have already been well covered by other test suites introduced in #3644.

Review on Reviewable

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25801 has started for PR 4116 at commit 20a7f9b.

  • This patch merges cleanly.

@liancheng liancheng force-pushed the remove-deprecated-parquet-tests branch from 20a7f9b to abd7033 Compare January 20, 2015 07:27
@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25804 has started for PR 4116 at commit abd7033.

  • This patch merges cleanly.

@liancheng liancheng mentioned this pull request Jan 20, 2015
Closed
@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25801 has finished for PR 4116 at commit 20a7f9b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ParquetQuerySuite extends QueryTest with ParquetTest

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25801/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 20, 2015

Test build #25804 has finished for PR 4116 at commit abd7033.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds the following public classes (experimental):
    • class ParquetQuerySuite extends QueryTest with ParquetTest

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 20, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25804/
Test PASSed.

@liancheng liancheng force-pushed the remove-deprecated-parquet-tests branch from abd7033 to 4282182 Compare January 21, 2015 19:13
@liancheng
Removes deprecated Parquet test suite
f73b8f9 
- Removes old ParquetQuerySuite
- Renames ParquetQuerySuite2 to ParquetQuerySuite
- Refactors ParquetFilterSuite
@liancheng liancheng force-pushed the remove-deprecated-parquet-tests branch from 4282182 to f73b8f9 Compare January 21, 2015 19:15
@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25897 has started for PR 4116 at commit f73b8f9.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 21, 2015

Test build #25897 has finished for PR 4116 at commit f73b8f9.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Jan 21, 2015

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25897/
Test PASSed.

@rxin
Copy link
Contributor

rxin commented Jan 21, 2015

Merging in master. Thanks!

@asfgit asfgit closed this in ba19689 Jan 21, 2015
bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 22, 2015
@liancheng @bomeng
[SQL] [Minor] Remove deprecated parquet tests
b32d256 
This PR removes the deprecated `ParquetQuerySuite`, renamed `ParquetQuerySuite2` to `ParquetQuerySuite`, and refactored changes introduced in apache#4115 to `ParquetFilterSuite` . It is a follow-up of apache#3644.

Notice that test cases in the old `ParquetQuerySuite` have already been well covered by other test suites introduced in apache#3644.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/4116)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes apache#4116 from liancheng/remove-deprecated-parquet-tests and squashes the following commits:

f73b8f9 [Cheng Lian] Removes deprecated Parquet test suite
@liancheng liancheng mentioned this pull request Mar 13, 2015
Closed
asfgit pushed a commit that referenced this pull request Mar 13, 2015
@liancheng
[SPARK-6285] [SQL] Removes unused ParquetTestData and duplicated Test…
cdc34ed 
…GroupWriteSupport

All the contents in this file are not referenced anywhere and should have been removed in #4116 when I tried to get rid of the old Parquet test suites.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/apache/spark/5010)
<!-- Reviewable:end -->

Author: Cheng Lian <[email protected]>

Closes #5010 from liancheng/spark-6285 and squashes the following commits:

06ed057 [Cheng Lian] Removes unused ParquetTestData and duplicated TestGroupWriteSupport
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liancheng @SparkQA @AmplabJenkins @rxin