[SPARK-43327][CORE][3.3] Trigger committer.setupJob before plan execute in FileFormatWriter#write
#41154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzzzming95
commented
May 12, 2023
| } | ||
| } | ||
|
|
||
| test("SPARK-43327: location exists when insertoverwrite fails") { |
Contributor
Author
There was a problem hiding this comment.
This issue did not occur in the latest master branch, only in Spark3.2 and Spark3.3
HyukjinKwon
changed the title
committer.setupJob before plan execute in FileFormatWriter#writecommitter.setupJob before plan execute in FileFormatWriter#write
HyukjinKwon
changed the title
committer.setupJob before plan execute in FileFormatWriter#writecommitter.setupJob before plan execute in FileFormatWriter#write
Member
|
@zzzzming95 do you know in which PR fixed the issue in master branch? |
Contributor
Author
The direct reason is because SPARK-37287, It causes' DataWriteingCommandExec 'to be encapsulated in' AdaptiveSparkPlanExec 'and triggers execution in advance. mabay we can just backport |
Contributor
|
SPARK-37287 is too big to backport |
cloud-fan
reviewed
Jun 19, 2023
| sql("create table t1(c2 long) using parquet") | ||
| sql("INSERT OVERWRITE TABLE t1 select 6000044164") | ||
|
|
||
| // spark.sql("CREATE TABLE IF NOT EXISTS t(amt1 int) using ORC") |
cloud-fan
approved these changes
Aug 14, 2023
cloud-fan
approved these changes
Aug 14, 2023
Contributor
Author
|
do you know how to make it run green ? I see all test pass. Or it can merge directly? please take a look , thanks~ |
Contributor
|
yea all tests passed, let me just merge it. Thanks! |
cloud-fan
pushed a commit
that referenced
this pull request
Aug 22, 2023
…cute in `FileFormatWriter#write` ### What changes were proposed in this pull request? Trigger `committer.setupJob` before plan execute in `FileFormatWriter#write` ### Why are the changes needed? In this issue, the case where `outputOrdering` might not work if AQE is enabled has been resolved. #38358 However, since it materializes the AQE plan in advance (triggers getFinalPhysicalPlan) , it may cause the committer.setupJob(job) to not execute When `AdaptiveSparkPlanExec#getFinalPhysicalPlan()` is executed with an error. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? add UT Closes #41154 from zzzzming95/spark3-SPARK-43327. Lead-authored-by: zzzzming95 <[email protected]> Co-authored-by: zhiming she <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
@cloud-fan |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Trigger
committer.setupJobbefore plan execute inFileFormatWriter#writeWhy are the changes needed?
In this issue, the case where
outputOrderingmight not work if AQE is enabled has been resolved.#38358
However, since it materializes the AQE plan in advance (triggers getFinalPhysicalPlan) , it may cause the committer.setupJob(job) to not execute When
AdaptiveSparkPlanExec#getFinalPhysicalPlan()is executed with an error.Does this PR introduce any user-facing change?
no
How was this patch tested?
add UT