Skip to content

Conversation

@pan3793
Copy link
Member

@pan3793 pan3793 commented Apr 28, 2023

What changes were proposed in this pull request?

Call Hive 2.3.9 API directly instead of reflection, basically reverts SPARK-37446.

Why are the changes needed?

Switch to direct calling to achieve compile time check.

Spark does not officially support building against Hive other than 2.3.9, for cases listed in SPARK-37446, it's the vendor's responsibility to port HIVE-21563 into their maintained Hive 2.3.8-[vender-custom-version].

See full discussion in #40893.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@github-actions github-actions bot added the SQL label Apr 28, 2023
@pan3793
Copy link
Member Author

pan3793 commented Apr 28, 2023

cc @srowen @sunchao @AngersZhuuuu

@srowen
Copy link
Member

srowen commented Apr 29, 2023

Merged to master

@srowen srowen closed this in aed6a47 Apr 29, 2023
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @sunchao once more~

@sunchao
Copy link
Member

sunchao commented May 1, 2023

Late LGTM. Was trying to +1 and merge this but @srowen beat me on it.

LuciferYang pushed a commit to LuciferYang/spark that referenced this pull request May 10, 2023
### What changes were proposed in this pull request?

Call Hive 2.3.9 API directly instead of reflection, basically reverts SPARK-37446.

### Why are the changes needed?

Switch to direct calling to achieve compile time check.

Spark does not officially support building against Hive other than 2.3.9, for cases listed in SPARK-37446, it's the vendor's responsibility to port HIVE-21563 into their maintained Hive 2.3.8-[vender-custom-version].

See full discussion in apache#40893.

### Does this PR introduce _any_ user-facing change?

No.

### How was this patch tested?

Pass GA.

Closes apache#40995 from pan3793/SPARK-43320.

Authored-by: Cheng Pan <[email protected]>
Signed-off-by: Sean Owen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants