[SPARK-43124][SQL] Dataset.show projects CommandResults locally #40779
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
cc @cloud-fan, please let me know if you have a better idea. |
Contributor
|
shall we update |
Contributor
|
or a more surgical way is to update |
Contributor
Author
Thanks, that's a good idea! |
Contributor
Author
|
Updated to |
cloud-fan
reviewed
Apr 13, 2023
| } else { | ||
| Column(col).cast(StringType) | ||
| } | ||
| val data = newDf.logicalPlan match { |
Contributor
There was a problem hiding this comment.
to deduplicate code, how about
val newDf = logicalPlan match {
case c: CommandResult =>
Dataset.ofRows(sparkSession, LocalRelation(c.output, c.rows)
case _ => toDf()
}
same code as before...
Contributor
Author
There was a problem hiding this comment.
But then we would rely on running ConvertToLocalRelation that can be excluded. Isn't that an issue?
Contributor
There was a problem hiding this comment.
if people exclude ConvertToLocalRelation, then we shouldn't do local evaluation here as well.
Contributor
Author
There was a problem hiding this comment.
All right, then d8210ff contains the deduplication. Thanks for the idea.
HyukjinKwon
approved these changes
Apr 14, 2023
…124-dataset-show-projects-commandresults-locally # Conflicts: # sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
jerqi
approved these changes
Apr 20, 2023
Member
|
Merged to master. |
Contributor
Author
|
Thanks all for the review! |
cloud-fan
pushed a commit
that referenced
this pull request
Mar 11, 2024
### What changes were proposed in this pull request? Similar to #40779, `Dataset.isEmpty` should also not trigger job execution on CommandResults. This PR converts `CommandResult` to `LocalRelation` in `Dataset.isEmpty` method. ### Why are the changes needed? A simple `spark.sql("show tables").isEmpty` shouldn not require an executor. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added new UT. ### Was this patch authored or co-authored using generative AI tooling? No Closes #45373 from wForget/SPARK-47270. Authored-by: Zhen Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
sweisdb
pushed a commit
to sweisdb/spark
that referenced
this pull request
Apr 1, 2024
### What changes were proposed in this pull request? Similar to apache#40779, `Dataset.isEmpty` should also not trigger job execution on CommandResults. This PR converts `CommandResult` to `LocalRelation` in `Dataset.isEmpty` method. ### Why are the changes needed? A simple `spark.sql("show tables").isEmpty` shouldn not require an executor. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added new UT. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45373 from wForget/SPARK-47270. Authored-by: Zhen Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
peter-toth
added a commit
to peter-toth/spark
that referenced
this pull request
Nov 26, 2024
…ocally `DataSet.show()` currently triggers a job for a simple `show tables` command. This is because the command output contains an `isTemporary` boolean column that needs to be casted to string when we use `show()` on the dataset. This PR converts `CommandResult` to `LocalRelation` and let `ConvertToLocalRelation` to do the casting locally to avoid triggering job execution. A simple `show tables` shouldn not require an executor. No. Added new UT. Closes apache#40779 from peter-toth/SPARK-43124-dataset-show-projects-commandresults-locally. Change-Id: I9971d7ee1f5385bcaf018dee0dd81b3ae3ac33ae Authored-by: Peter Toth <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
turboFei
added a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…s locally (apache#600) [SPARK-47270][SQL] Dataset.isEmpty projects CommandResults locally ### What changes were proposed in this pull request? Similar to apache#40779, `Dataset.isEmpty` should also not trigger job execution on CommandResults. This PR converts `CommandResult` to `LocalRelation` in `Dataset.isEmpty` method. ### Why are the changes needed? A simple `spark.sql("show tables").isEmpty` shouldn not require an executor. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added new UT. ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#45373 from wForget/SPARK-47270. Authored-by: Zhen Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> Co-authored-by: Zhen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
DataSet.show()currently triggers a job for a simpleshow tablescommand. This is because the command output contains anisTemporaryboolean column that needs to be casted to string when we useshow()on the dataset.This PR converts
CommandResulttoLocalRelationand letConvertToLocalRelationto do the casting locally to avoid triggering job execution.Why are the changes needed?
A simple
show tablesshouldn not require an executor.Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new UT.