-
Notifications
You must be signed in to change notification settings - Fork 28.9k
[SPARK-42921][SQL][TESTS] Split timestampNTZ/datetime-special.sql into w/ and w/o ansi suffix to pass sql analyzer test in ansi mode
#40552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
timestampNTZ/datetime-special.sql into w/ and w/o ansi for testtimestampNTZ/datetime-special.sql into w/ and w/o ansi for fix sql analyzer test
|
cc @dtenedor @HyukjinKwon FYI |
timestampNTZ/datetime-special.sql into w/ and w/o ansi for fix sql analyzer testtimestampNTZ/datetime-special.sql into w/ and w/o ansi suffix to fix sql analyzer test
timestampNTZ/datetime-special.sql into w/ and w/o ansi suffix to fix sql analyzer testtimestampNTZ/datetime-special.sql into w/ and w/o ansi suffix to pass sql analyzer test
timestampNTZ/datetime-special.sql into w/ and w/o ansi suffix to pass sql analyzer testtimestampNTZ/datetime-special.sql into w/ and w/o ansi suffix to pass sql analyzer test in ansi mode
|
I am so sorry to break the build again :| thanks for fixing it! It looks like we need separate regular and ANSI test cases now! |
| "ansi/datetime-special.sql", | ||
| "timestampNTZ/datetime-special.sql", | ||
| // SPARK-42921 | ||
| "timestampNTZ/datetime-special-ansi.sql", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore in ThriftServerQueryTestSuite, same reason as timestampNTZ/datetime-special.sql
|
Merged to master. |
|
Thanks @HyukjinKwon @dtenedor |
What changes were proposed in this pull request?
After #40496, run
There is one test faild with
spark.sql.ansi.enabled = trueThe failure reason is the last parameter of function
MakeDateisfailOnError: Boolean = SQLConf.get.ansiEnabled.So this pr split
timestampNTZ/datetime-special.sqlinto w/ and w/o ansi to mask this test difference.Why are the changes needed?
Make SQLQueryTestSuite test pass with
spark.sql.ansi.enabled = true.Does this PR introduce any user-facing change?
No
How was this patch tested?
SPARK_ANSI_SQL_MODE=true build/sbt "sql/testOnly org.apache.spark.sql.SQLQueryTestSuite"