Skip to content

Conversation

@adrian-wang
Copy link
Contributor

No description provided.

@SparkQA
Copy link

SparkQA commented Jan 14, 2015

Test build #25530 has started for PR 4040 at commit 0ac8e8f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 14, 2015

Test build #25530 has finished for PR 4040 at commit 0ac8e8f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25530/
Test PASSed.

@adrian-wang adrian-wang changed the title [SPARK-5244] [SQL] add coalesce() in sql parser [SPARK-5244] [SQL] [WIP] add coalesce() in sql parser Jan 20, 2015
@adrian-wang adrian-wang changed the title [SPARK-5244] [SQL] [WIP] add coalesce() in sql parser [SPARK-5244] [SQL] add coalesce() in sql parser Jan 20, 2015
@asfgit asfgit closed this in 812d367 Jan 21, 2015
@JoshRosen
Copy link
Contributor

I've reverted this PR because it conflicted with another PR and has led to test compilation failures in SQLQuerySuite:

[info] Compiling 25 Scala sources to /private/tmp/spark/sql/catalyst/target/scala-2.10/test-classes...
[info] Compiling 38 Scala sources and 3 Java sources to /private/tmp/spark/sql/core/target/scala-2.10/test-classes...
[error] /private/tmp/spark/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:90: overloaded method value checkAnswer with alternatives:
[error]   (rdd: org.apache.spark.sql.SchemaRDD,expectedAnswer: org.apache.spark.sql.Row)Unit <and>
[error]   (rdd: org.apache.spark.sql.SchemaRDD,expectedAnswer: Seq[org.apache.spark.sql.Row])Unit
[error]  cannot be applied to (org.apache.spark.sql.SchemaRDD, Int)
[error]     checkAnswer(
[error]     ^
[error] /private/tmp/spark/sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala:93: ambiguous reference to overloaded definition,
[error] both method checkAnswer in class QueryTest of type (rdd: org.apache.spark.sql.SchemaRDD, expectedAnswer: org.apache.spark.sql.Row)Unit
[error] and  method checkAnswer in class QueryTest of type (rdd: org.apache.spark.sql.SchemaRDD, expectedAnswer: Seq[org.apache.spark.sql.Row])Unit
[error] match argument types (org.apache.spark.sql.SchemaRDD,Null)
[error]     checkAnswer(
[error]     ^
[error] two errors found
[error] (sql/test:compile) Compilation failed
[error] Total time: 29 s, completed Jan 21, 2015 2:24:18 PM

I'm reverting now to unblock pull request testing.

I believe that this may have been due to some recent refactoring in other parts of SQL, which Jenkins didn't detect because this wasn't retested recently.

bomeng pushed a commit to Huawei-Spark/spark that referenced this pull request Jan 22, 2015
Author: Daoyuan Wang <[email protected]>

Closes apache#4040 from adrian-wang/coalesce and squashes the following commits:

0ac8e8f [Daoyuan Wang] add coalesce() in sql parser
@adrian-wang
Copy link
Contributor Author

I have put code here together into #4057

asfgit pushed a commit that referenced this pull request Feb 2, 2015
…ypes for parameters of coalesce

I'll add test case in #4040

Author: Daoyuan Wang <[email protected]>

Closes #4057 from adrian-wang/coal and squashes the following commits:

4d0111a [Daoyuan Wang] address Yin's comments
c393e18 [Daoyuan Wang] fix rebase conflicts
e47c03a [Daoyuan Wang] add coalesce in parser
c74828d [Daoyuan Wang] cast types for coalesce
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants