[SPARK-42216][CORE][TESTS] Fix two check conditions and remove redundant toMap in util.JsonProtocolSuite
#39772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| assertEquals(e1.executorInfo, e2.executorInfo) | ||
| case (e1: SparkListenerExecutorRemoved, e2: SparkListenerExecutorRemoved) => | ||
| assert(e1.executorId === e1.executorId) | ||
| assert(e1.executorId === e2.executorId) |
Member
There was a problem hiding this comment.
According to the PR description, after fixing this, toMap causes failure, right?
Contributor
Author
There was a problem hiding this comment.
No, two things have been done in this pr : one is code cleanup, the other is bug fix.
Is it better to divide this pr into two parts?
Sorry, my descriptive ability is poor. It seems that there is a misunderstanding ...
Contributor
Author
There was a problem hiding this comment.
According to the PR description, after fixing this,
toMapcauses failure, right?
After fixing this, toMap is redundant collection conversion
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Since this is related to Map, please test Scala 2.13 together.
Contributor
Author
done |
dongjoon-hyun
changed the title
immutable.Map by default and fix two check conditions in util.JsonProtocolSuitetoMap in util.JsonProtocolSuite
Contributor
Author
|
Thanks @dongjoon-hyun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The main changes of this pr as follows:
Remove explicit
import scala.collection.Mapand use the defaultimmutable.Mapinutil.JsonProtocolSuite, and also clean up the redundanttoMapconversion after remove explicitimport scala.collection.MapFix two
assertconditions: changeassert(e1.x === e1.x)toassert(e1.x === e2.x), the originally assert is always true.Why are the changes needed?
immutable.Mapby default inutil.JsonProtocolSuiteand remove redundanttoMapconversion for code cleanuputil.JsonProtocolSuiteDoes this PR introduce any user-facing change?
No, just for test
How was this patch tested?
all test passed