[SPARK-42133] Add basic Dataset API methods to Spark Connect Scala Client #39672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
zhenlineo
reviewed
Jan 23, 2023
|
|
||
| private var server: Server = _ | ||
| private var service: DummySparkConnectService = _ | ||
| private val SERVER_PORT = 15250 |
Contributor
There was a problem hiding this comment.
Can we not fix the port but give the dummy server 0 and let the sever return the bind port for client?
Contributor
Author
There was a problem hiding this comment.
Good idea, I've updated the logic with this approach.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Adds the following methods:
This PR also introduces
Columnandfunctionsto support the above changes.Why are the changes needed?
Incremental development of Spark Connect Scala Client.
Does this PR introduce any user-facing change?
Yes, users may now use the proposed API methods.
Example:
val df = sparkSession.range(5).limit(3)How was this patch tested?
Unit tests + simple E2E test.