Skip to content

Conversation

@scwf
Copy link
Contributor

@scwf scwf commented Jan 8, 2015

Follow up for #3712.
This PR finally remove CommandStrategy and make all commands follow RunnableCommand so they can go with case r: RunnableCommand => ExecutedCommand(r) :: Nil.

One exception is the DescribeCommand of hive, which is a special case and need to distinguish hive table and temporary table, so still keep HiveCommandStrategy here.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

Test build #25217 has started for PR 3948 at commit 6677766.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

Test build #25217 has finished for PR 3948 at commit 6677766.

  • This patch fails to build.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25217/
Test FAILed.

@scwf scwf force-pushed the followup-SPARK-4861 branch from 6677766 to 2c62e9d Compare January 8, 2015 09:39
@SparkQA
Copy link

SparkQA commented Jan 8, 2015

Test build #25218 has started for PR 3948 at commit 2c62e9d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

Test build #25220 has started for PR 3948 at commit 6b48e64.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

Test build #25218 has finished for PR 3948 at commit 2c62e9d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25218/
Test PASSed.

@SparkQA
Copy link

SparkQA commented Jan 8, 2015

Test build #25220 has finished for PR 3948 at commit 6b48e64.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25220/
Test PASSed.

@scwf
Copy link
Contributor Author

scwf commented Jan 8, 2015

/cc @marmbrus

@marmbrus
Copy link
Contributor

Thanks, merging to master.

@asfgit asfgit closed this in b3e86dc Jan 10, 2015
@scwf scwf deleted the followup-SPARK-4861 branch January 10, 2015 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants