[SPARK-38173][SQL][3.2] Quoted column cannot be recognized correctly when quotedRegexColumnNames is true #39473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when quotedRegexColumnNames is true
dongjoon-hyun
approved these changes
Jan 10, 2023
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (Pending CIs). Thank you, @huaxingao .
Also, cc @sunchao
sunchao
approved these changes
Jan 10, 2023
Member
|
Could you re-trigger the timeouted GitHub Action job, @huaxingao ? |
Contributor
Author
|
All the tests passed now :) |
Member
|
Thank you. Merged to branch-3.2. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jan 10, 2023
…when quotedRegexColumnNames is true ### What changes were proposed in this pull request? backporting #35476 to 3.2 ### Why are the changes needed? bug fixing in 3.2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new UT Closes #39473 from huaxingao/3.2. Authored-by: huaxingao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Contributor
Author
|
Thanks a lot @dongjoon-hyun @sunchao |
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
…when quotedRegexColumnNames is true ### What changes were proposed in this pull request? backporting apache#35476 to 3.2 ### Why are the changes needed? bug fixing in 3.2 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? new UT Closes apache#39473 from huaxingao/3.2. Authored-by: huaxingao <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
backporting #35476 to 3.2
Why are the changes needed?
bug fixing in 3.2
Does this PR introduce any user-facing change?
No
How was this patch tested?
new UT