[SPARK-5141][SQL]CaseInsensitiveMap throws java.io.NotSerializableException

[luogankun]

CaseInsensitiveMap throws java.io.NotSerializableException.

[AmplabJenkins]

Can one of the admins verify this patch?

[scwf]

Aactually i do not think we should make CaseInsensitiveMap serializable since it only used to pass parameters in driver

[rxin]

Can you give more information on cases when this causes problem?

[luogankun]

According to Yin Huai in https://issues.apache.org/jira/browse/SPARK-5141 , set jdbcProps transient. Resolved this issue. I will close the pr.

[yhuai]

@rxin CaseInsensitiveMap is used to pass options to a user defined relation resolver for creating a relation. If this map is passed into the created relation, we will try to serialize it with the closure.

@marmbrus and I talked about it offline yesterday. Maybe it is a good idea to just make it serializable. So, developers will not need to worry about this issue at all.

[rxin]

sgtm to make it serializable, and also fixing the transient problem.

[yhuai]

@luogankun Can you reopen it? Thank you and sorry about the inconvenience.

[AmplabJenkins]

Can one of the admins verify this patch?

[marmbrus]

ok to test

[SparkQA]

Test build #25352 has started for PR 3944 at commit b6d63d5.

• This patch merges cleanly.

[SparkQA]

Test build #25352 has finished for PR 3944 at commit b6d63d5.

• This patch passes all tests.
• This patch merges cleanly.
• This patch adds the following public classes (experimental):
  • protected class CaseInsensitiveMap(map: Map[String, String]) extends Map[String, String]

[AmplabJenkins]

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25352/
Test PASSed.

[scwf]

oh, since users may pass the CaseInsensitiveMap into scan builder relation, make it Serializable more robust. this LGTM.

[rxin]

Merging in master. Thanks!