Skip to content

Conversation

@LuciferYang
Copy link
Contributor

@LuciferYang LuciferYang commented Dec 31, 2022

What changes were proposed in this pull request?

This pr aims upgrade Apache httpcore from 4.4.14 to 4.4.16.

Why are the changes needed?

The new version bring some bugs fix:

  • HTTPCORE-695: Unhandled CancelledKeyException during processPendingInterestOps leads to a shutdown of the underlying IOReactor.
  • HTTPCORE-687: Non-blocking SSL I/O session can enter a tight loop if the SSL session gets closed by the protocol layer while there is still unprocessed data stuck in the protocol session buffer.
  • HTTPCORE-660: Convert RuntimeExceptions thrown by SSLSetupHandler#verify to SSLExceptions.
  • HTTPCORE-730: Non-blocking SSL I/O session incorrectly sets read interest when the session is being closed even if the application layer has cleared interest in input causing a busy loop in the I/O event loop and excessive CPU utilization.
  • HTTPCORE-720: Discard any remaining decrypted application data after the TLS session has been closed by the local endpoint.
  • HTTPCORE-716: Evict remaining decrypted input data from SSL I/O session buffers upon session closure. With unexpected input in the session buffers I/O reactors could end up in a tight loop causing excessive CPU utilization.

The release notes as follows:

Does this PR introduce any user-facing change?

No

How was this patch tested?

Pass GitHub Actions

@github-actions github-actions bot added the BUILD label Dec 31, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. All tests passed. Merged to master.

Screenshot 2022-12-31 at 12 06 59 PM

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants