Skip to content

SPARK-1202: Improvements to task killing in the UI. #386

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SPARK-1202: Improvements to task killing in the UI. #386

wants to merge 1 commit into from

Conversation

@pwendell
Copy link
Contributor

@pwendell pwendell commented Apr 11, 2014

  1. Adds a separate endpoint for the killing logic that is outside of a page.
  2. Narrows the scope of the killingEnabled tracking.
  3. Some style improvements.

@pwendell
Improvements to task killing in the UI.
8efe02b 
1. Adds a separate endpoint for the killing logic that is outside of a page.
2. Narrows the scope of the killingEnabled tracking.
3. Some style improvements.
@pwendell
Copy link
Contributor Author

pwendell commented Apr 11, 2014

These are some improvements on top of #246

@pwendell
Copy link
Contributor Author

pwendell commented Apr 11, 2014

Jenkins, test this please.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 11, 2014

Merged build triggered.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 11, 2014

Merged build started.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 11, 2014

Merged build finished. All automated tests passed.

@AmplabJenkins
Copy link

AmplabJenkins commented Apr 11, 2014

All automated tests passed.
Refer to this link for build results: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/14035/

@pwendell
Copy link
Contributor Author

pwendell commented Apr 11, 2014

Thanks - merged!

@pwendell
Copy link
Contributor Author

pwendell commented Apr 11, 2014

Ha I guess it's kinda weird to say thanks when merging my own pull request - oops.

asfgit pushed a commit that referenced this pull request Apr 11, 2014
@pwendell
SPARK-1202: Improvements to task killing in the UI.
a1bb4c6 
1. Adds a separate endpoint for the killing logic that is outside of a page.
2. Narrows the scope of the killingEnabled tracking.
3. Some style improvements.

Author: Patrick Wendell <[email protected]>

Closes #386 from pwendell/kill-link and squashes the following commits:

8efe02b [Patrick Wendell] Improvements to task killing in the UI.
(cherry picked from commit 44f654e)

Signed-off-by: Patrick Wendell <[email protected]>
@asfgit asfgit closed this in 44f654e Apr 11, 2014
pdeyhim pushed a commit to pdeyhim/spark-1 that referenced this pull request Jun 25, 2014
@pwendell @pdeyhim
SPARK-1202: Improvements to task killing in the UI.
6dd19a8 
1. Adds a separate endpoint for the killing logic that is outside of a page.
2. Narrows the scope of the killingEnabled tracking.
3. Some style improvements.

Author: Patrick Wendell <[email protected]>

Closes apache#386 from pwendell/kill-link and squashes the following commits:

8efe02b [Patrick Wendell] Improvements to task killing in the UI.
mccheah pushed a commit to mccheah/spark that referenced this pull request Nov 28, 2018
@robert3005
Merge pull request apache#386 from palantir/rk/more-upstream
771a5c7
bzhaoopenstack pushed a commit to bzhaoopenstack/spark that referenced this pull request Sep 11, 2019
@kiwik
Enable S3 test cases in fusioncloud job (apache#386)
bf8738f 
Related-Bug: theopenlab/openlab#130
turboFei pushed a commit to turboFei/spark that referenced this pull request Nov 6, 2025
@wangyum @gengliangwang
[SPARK-48016][SQL][3.5] Fix a bug in try_divide function when with de…
14f73ad 
…cimals (apache#386)

### What changes were proposed in this pull request?

 Currently, the following query will throw DIVIDE_BY_ZERO error instead of returning null
 ```
SELECT try_divide(1, decimal(0));
```

This is caused by the rule `DecimalPrecision`:
```
case b  BinaryOperator(left, right) if left.dataType != right.dataType =>
  (left, right) match {
 ...
    case (l: Literal, r) if r.dataType.isInstanceOf[DecimalType] &&
        l.dataType.isInstanceOf[IntegralType] &&
        literalPickMinimumPrecision =>
      b.makeCopy(Array(Cast(l, DataTypeUtils.fromLiteral(l)), r))
```
The result of the above makeCopy will contain `ANSI` as the `evalMode`, instead of `TRY`.
This PR is to fix this bug by replacing the makeCopy method calls with withNewChildren

### Why are the changes needed?

Bug fix in try_* functions.

### Does this PR introduce _any_ user-facing change?

Yes, it fixes a long-standing bug in the try_divide function.

### How was this patch tested?

New UT

### Was this patch authored or co-authored using generative AI tooling?

No

Closes apache#46323 from gengliangwang/pickFix.

Authored-by: Gengliang Wang <[email protected]>

Signed-off-by: Gengliang Wang <[email protected]>
Co-authored-by: Gengliang Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pwendell @AmplabJenkins