[Fix #204] Update out-dated comments #381
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged build triggered. |
|
Merged build started. |
|
Merged build finished. All automated tests passed. |
|
All automated tests passed. |
Contributor
|
Thanks - merged. |
asfgit
pushed a commit
that referenced
this pull request
Apr 12, 2014
This PR is self-explanatory. Author: Andrew Or <[email protected]> Closes #381 from andrewor14/master and squashes the following commits: 3e8dde2 [Andrew Or] Fix comments for #204 (cherry picked from commit c2d160f) Signed-off-by: Patrick Wendell <[email protected]>
pwendell
added a commit
to pwendell/spark
that referenced
this pull request
May 12, 2014
Better error handling in Spark Streaming and more API cleanup Earlier errors in jobs generated by Spark Streaming (or in the generation of jobs) could not be caught from the main driver thread (i.e. the thread that called StreamingContext.start()) as it would be thrown in different threads. With this change, after `ssc.start`, one can call `ssc.awaitTermination()` which will be block until the ssc is closed, or there is an exception. This makes it easier to debug. This change also adds ssc.stop(<stop-spark-context>) where you can stop StreamingContext without stopping the SparkContext. Also fixes the bug that came up with PRs apache#393 and apache#381. MetadataCleaner default value has been changed from 3500 to -1 for normal SparkContext and 3600 when creating a StreamingContext. Also, updated StreamingListenerBus with changes similar to SparkListenerBus in apache#392. And changed a lot of protected[streaming] to private[streaming].
pdeyhim
pushed a commit
to pdeyhim/spark-1
that referenced
this pull request
Jun 25, 2014
This PR is self-explanatory. Author: Andrew Or <[email protected]> Closes apache#381 from andrewor14/master and squashes the following commits: 3e8dde2 [Andrew Or] Fix comments for apache#204
mccheah
added a commit
to mccheah/spark
that referenced
this pull request
Nov 28, 2018
…ons (apache#381) * Implement a Docker image generator gradle plugin for Spark applications. * Fix circle * Fix more circle * No need to setup docker for compilation only * Fix gradle * Add license headers * Address comments. * Remove extra task * Remove 2.11 * Remove extra script * Remove some imports * Add more tests * Don't bundle resources in tgz, just include individual files in resources. * Fix license placement. * Use InputFile and not Input * Fix build * Add back K8s integration tests * Revert changes to SparkBuild * Remove hive version 2.0.2 from test suite * Use shared Spark session for unsafe row suite * Revert "Use shared Spark session for unsafe row suite" This reverts commit 1ae4f61. * Address comments. - Move Gradle project to the root directory - Use Gradle 4.9 - More properties - Use baseline * Fix build script * Fix build again * Fix licenses and ignore build dir licenses * Remove extraneous scripts
bzhaoopenstack
pushed a commit
to bzhaoopenstack/spark
that referenced
this pull request
Sep 11, 2019
Disable test cases that cause panic
holdenk
pushed a commit
to holdenk/spark
that referenced
this pull request
Sep 12, 2019
Initialize UrlStreamHandlerFactory per jvm and fix typo.
turboFei
pushed a commit
to turboFei/spark
that referenced
this pull request
Nov 6, 2025
…n type of boolean (apache#381) Backports apache#45589 to 3.5 ### What changes were proposed in this pull request? Use V2Predicate to wrap If expr when building v2 expressions. ### Why are the changes needed? The `PushFoldableIntoBranches` optimizer may fold predicate into (if / case) branches and `V2ExpressionBuilder` wraps `If` as `GeneralScalarExpression`, which causes the assertion in `PushablePredicate.unapply` to fail. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? added unit test ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#46074 from wForget/SPARK-47463_3.5. Authored-by: Zhen Wang <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> Co-authored-by: Zhen Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is self-explanatory.