[SPARK-40260][SQL] Use error classes in the compilation errors of GROUP BY a position #37712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxGekk
changed the title
MaxGekk
changed the title
Member
Author
cloud-fan
approved these changes
Aug 30, 2022
srielau
approved these changes
Aug 30, 2022
Contributor
srielau
left a comment
srielau
left a comment
There was a problem hiding this comment.
Nit on the wording, LGTM otherwise
Co-authored-by: Serge Rielau <[email protected]>
Member
Author
|
Merging to master. Thank you, @srielau @cloud-fan for review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
In the PR, I propose to the following new error classes:
and migrate 2 compilation exceptions related to GROUP BY a position onto them.
Why are the changes needed?
The migration onto error classes makes the errors searchable in docs, and allows to edit error's text messages w/o modifying the source code.
Does this PR introduce any user-facing change?
Yes, in some sense because it modifies user-facing error messages.
How was this patch tested?
By running the affected test suites: