Skip to content

[SPARK-4887][MLlib] Fix a bad unittest in LogisticRegressionSuite #3735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-4887][MLlib] Fix a bad unittest in LogisticRegressionSuite #3735

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions mllib/src/test/scala/org/apache/spark/mllib/classification/LogisticRegressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,15 +178,16 @@ class LogisticRegressionSuite extends FunSuite with MLlibTestSparkContext with M
// Use half as many iterations as the previous test.
val lr = new LogisticRegressionWithSGD().setIntercept(true)
lr.optimizer.
setStepSize(10.0).
setStepSize(1.0).
setNumIterations(10).
setRegParam(1.0)

val model = lr.run(testRDD, initialWeights)

// Test the weights
assert(model.weights(0) ~== -430000.0 relTol 20000.0)
assert(model.intercept ~== 370000.0 relTol 20000.0)
// With regularization, the resulting weights will be smaller.
assert(model.weights(0) ~== -0.14 relTol 0.02)
assert(model.intercept ~== 0.25 relTol 0.02)

val validationData = LogisticRegressionSuite.generateLogisticInput(A, B, nPoints, 17)
val validationRDD = sc.parallelize(validationData, 2)
Expand Down