Skip to content

Conversation

@msiddalingaiah
Copy link
Contributor

@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@ash211
Copy link
Contributor

ash211 commented Dec 18, 2014

Ok to test

@ash211
Copy link
Contributor

ash211 commented Dec 18, 2014

Also @msiddalingaiah commits should typically have a SPARK jira ticket associated with them so we can properly credit contributors when we do release notes, plus tie a commit back to discussion on a Jira ticket. Would you mind filing a ticket (even for this small change) and add it to the title?

The preferred contribution process is documented here: https://cwiki.apache.org/confluence/display/SPARK/Contributing+to+Spark

This particular commit is so small it's hardly worth the effort, but I do think it's a good habit to get into for even the smallest of changes for future contributors looking to track the history of a change.

Thanks!

@ash211
Copy link
Contributor

ash211 commented Dec 18, 2014

ok to test

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24573 has started for PR 3722 at commit 79e679f.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Dec 18, 2014

Test build #24573 has finished for PR 3722 at commit 79e679f.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24573/
Test PASSed.

@msiddalingaiah msiddalingaiah changed the title [DOC]: Improve Partition docs [SPARK-4884]: Improve Partition docs Dec 18, 2014
@msiddalingaiah
Copy link
Contributor Author

@ash211 Not a problem, I created a JIRA ticket and updated the title/description.
I can't seem to assign the issue to myself, can you help with that?
Thanks!!

@ash211
Copy link
Contributor

ash211 commented Dec 18, 2014

+1

asfgit pushed a commit that referenced this pull request Dec 19, 2014
Rewording was based on this discussion: http://apache-spark-developers-list.1001551.n3.nabble.com/RDD-data-flow-td9804.html
This is the associated JIRA ticket: https://issues.apache.org/jira/browse/SPARK-4884

Author: Madhu Siddalingaiah <[email protected]>

Closes #3722 from msiddalingaiah/master and squashes the following commits:

79e679f [Madhu Siddalingaiah] [DOC]: improve documentation
51d14b9 [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
38faca4 [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
cbccbfe [Madhu Siddalingaiah] Documentation: replace <b> with <code> (again)
332f7a2 [Madhu Siddalingaiah] Documentation: replace <b> with <code>
cd2b05a [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
0fc12d7 [Madhu Siddalingaiah] Documentation: add description for repartitionAndSortWithinPartitions

(cherry picked from commit d5a596d)
Signed-off-by: Josh Rosen <[email protected]>
asfgit pushed a commit that referenced this pull request Dec 19, 2014
Rewording was based on this discussion: http://apache-spark-developers-list.1001551.n3.nabble.com/RDD-data-flow-td9804.html
This is the associated JIRA ticket: https://issues.apache.org/jira/browse/SPARK-4884

Author: Madhu Siddalingaiah <[email protected]>

Closes #3722 from msiddalingaiah/master and squashes the following commits:

79e679f [Madhu Siddalingaiah] [DOC]: improve documentation
51d14b9 [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
38faca4 [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
cbccbfe [Madhu Siddalingaiah] Documentation: replace <b> with <code> (again)
332f7a2 [Madhu Siddalingaiah] Documentation: replace <b> with <code>
cd2b05a [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
0fc12d7 [Madhu Siddalingaiah] Documentation: add description for repartitionAndSortWithinPartitions

(cherry picked from commit d5a596d)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in d5a596d Dec 19, 2014
asfgit pushed a commit that referenced this pull request Dec 19, 2014
Rewording was based on this discussion: http://apache-spark-developers-list.1001551.n3.nabble.com/RDD-data-flow-td9804.html
This is the associated JIRA ticket: https://issues.apache.org/jira/browse/SPARK-4884

Author: Madhu Siddalingaiah <[email protected]>

Closes #3722 from msiddalingaiah/master and squashes the following commits:

79e679f [Madhu Siddalingaiah] [DOC]: improve documentation
51d14b9 [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
38faca4 [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
cbccbfe [Madhu Siddalingaiah] Documentation: replace <b> with <code> (again)
332f7a2 [Madhu Siddalingaiah] Documentation: replace <b> with <code>
cd2b05a [Madhu Siddalingaiah] Merge remote-tracking branch 'upstream/master'
0fc12d7 [Madhu Siddalingaiah] Documentation: add description for repartitionAndSortWithinPartitions

(cherry picked from commit d5a596d)
Signed-off-by: Josh Rosen <[email protected]>
@JoshRosen
Copy link
Contributor

LGTM, so I've merged this into all of the maintenance branches + master. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants