Skip to content

Conversation

@dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Jun 10, 2022

What changes were proposed in this pull request?

This is a follow-up of #36827 to update q83.sf100.ansi result.

Why are the changes needed?

ANSI mode unit tests are not covered on GitHub Action on PRs.

Does this PR introduce any user-facing change?

No.

How was this patch tested?

This should be tested manually because GitHub Action doesn't test this.

$ SPARK_ANSI_SQL_MODE=true build/sbt "sql/testOnly *PlanStabilityWithStatsSuite"

@dongjoon-hyun
Copy link
Member Author

Thank you again, @gengliangwang .

@dongjoon-hyun
Copy link
Member Author

Thank you, @huaxingao .

@dongjoon-hyun
Copy link
Member Author

This is also not tested by GitHub Action on PR.

According to the master branch status, this is the last failure and I also verified with the wildcard at this time.

SPARK_ANSI_SQL_MODE=true SPARK_GENERATE_GOLDEN_FILES=1 build/sbt "sql/testOnly *PlanStability*Suite"

I'm going to merge.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-39437-2 branch June 10, 2022 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants