[3.2][SPARK-39437][SQL][TEST] Normalize plan id separately in PlanStabilitySuite #36828
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dongjoon-hyun
approved these changes
Jun 10, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
The patch itself looks good if CI passes.
We need this at branch-3.3 first before landing at branch-3.2, don't we? @cloud-fan .
viirya
approved these changes
Jun 10, 2022
HyukjinKwon
approved these changes
Jun 10, 2022
Member
|
Could you fix more test failures, @cloud-fan ? |
Contributor
Author
|
Since this touches golden files, I'd like to have one PR per branch to be safe. |
Contributor
Author
|
thanks for the review, merging to 3.2! |
cloud-fan
added a commit
that referenced
this pull request
Jun 10, 2022
…bilitySuite backport #36827 ### What changes were proposed in this pull request? In `PlanStabilitySuite`, we normalize expression IDs by matching `#\d+` in the explain string. However, this regex can match plan id in `Exchange` node as well, which will mess up the normalization if expression IDs and plan IDs overlap. This PR normalizes plan id separately in `PlanStabilitySuite`. ### Why are the changes needed? Make the plan golden file more stable. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes #36828 from cloud-fan/test2. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Member
|
Thank you, @cloud-fan . I also merged #36827 . |
Contributor
|
Thanks @cloud-fan for the fix! Updated #36386 |
Member
|
Thank you, @allisonwang-db ! |
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Jun 2, 2023
…bilitySuite backport apache#36827 ### What changes were proposed in this pull request? In `PlanStabilitySuite`, we normalize expression IDs by matching `#\d+` in the explain string. However, this regex can match plan id in `Exchange` node as well, which will mess up the normalization if expression IDs and plan IDs overlap. This PR normalizes plan id separately in `PlanStabilitySuite`. ### Why are the changes needed? Make the plan golden file more stable. ### Does this PR introduce _any_ user-facing change? no ### How was this patch tested? N/A Closes apache#36828 from cloud-fan/test2. Authored-by: Wenchen Fan <[email protected]> Signed-off-by: Wenchen Fan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport #36827
What changes were proposed in this pull request?
In
PlanStabilitySuite, we normalize expression IDs by matching#\d+in the explain string. However, this regex can match plan id inExchangenode as well, which will mess up the normalization if expression IDs and plan IDs overlap.This PR normalizes plan id separately in
PlanStabilitySuite.Why are the changes needed?
Make the plan golden file more stable.
Does this PR introduce any user-facing change?
no
How was this patch tested?
N/A