[SPARK-39321][SQL] Refactor TryCast to use RuntimeReplaceable #36703
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cloud-fan
force-pushed
the
cast
branch
2 times, most recently
from
d1695e6 to
58bf9dd
Compare
Contributor
Author
beliefer
reviewed
Jun 1, 2022
Member
|
@cloud-fan Could you resolve conflicts, please. |
Member
There was a problem hiding this comment.
I am confused. The default value of USER_SPECIFIED_CAST seems to be false.
Contributor
Author
There was a problem hiding this comment.
USER_SPECIFIED_CAST is a TreeNodeTag that is only used by Cast, we don't need to set it in TryCast. Let me improve the comment.
gengliangwang
approved these changes
Jun 7, 2022
Member
gengliangwang
left a comment
gengliangwang
left a comment
There was a problem hiding this comment.
Thanks for the refactoring!
Contributor
Author
|
thanks for the review, merging to master! |
gengliangwang
added a commit
that referenced
this pull request
Aug 12, 2022
### What changes were proposed in this pull request? For the following query ``` SET spark.sql.ansi.enabled=true; SELECT try_cast(1/0 AS string); ``` Spark 3.3 will throw an exception for the division by zero error. In the current master branch, it returns null after the refactoring PR #36703 This PR is to restore the previous error handling syntax. ### Why are the changes needed? 1. Restore the behavior of try_cast() 2. The previous syntax is more reasonable. Users can cleanly catch the exception from the child of `try_cast`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit tests Closes #37486 from gengliangwang/restoreTryCast. Authored-by: Gengliang Wang <[email protected]> Signed-off-by: Gengliang Wang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR refactors
TryCastto useRuntimeReplaceable, so that we don't needCastBaseanymore. The unit tests are also simplified because we don't need to check the execution ofRuntimeReplaceable, but only the analysis behavior.Why are the changes needed?
code cleanup
Does this PR introduce any user-facing change?
no
How was this patch tested?
existing tests