Skip to content

[SPARK-39278][CORE] Fix backward compatibility of alternative configs of Hadoop Filesystems to access #36658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-39278][CORE] Fix backward compatibility of alternative configs of Hadoop Filesystems to access #36658

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/scala/org/apache/spark/SparkConf.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -714,8 +714,8 @@ private[spark] object SparkConf extends Logging {
KERBEROS_RELOGIN_PERIOD.key -> Seq(
AlternateConfig("spark.yarn.kerberos.relogin.period", "3.0")),
KERBEROS_FILESYSTEMS_TO_ACCESS.key -> Seq(
AlternateConfig("spark.yarn.access.namenodes", "2.2"),
AlternateConfig("spark.yarn.access.hadoopFileSystems", "3.0")),
AlternateConfig("spark.yarn.access.hadoopFileSystems", "3.0"),
AlternateConfig("spark.yarn.access.namenodes", "2.2")),
"spark.kafka.consumer.cache.capacity" -> Seq(
AlternateConfig("spark.sql.kafkaConsumerCache.capacity", "3.0"))
)
Expand Down
7 changes: 5 additions & 2 deletions core/src/test/scala/org/apache/spark/SparkConfSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,8 +277,11 @@ class SparkConfSuite extends SparkFunSuite with LocalSparkContext with ResetSyst
conf.set("spark.yarn.access.namenodes", "testNode")
assert(conf.get(KERBEROS_FILESYSTEMS_TO_ACCESS) === Array("testNode"))

conf.set("spark.yarn.access.hadoopFileSystems", "testNode")
Copy link
Member Author

@manuzhang manuzhang Jun 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to point out this test is meaningless before this change.

assert(conf.get(KERBEROS_FILESYSTEMS_TO_ACCESS) === Array("testNode"))
conf.set("spark.yarn.access.hadoopFileSystems", "testNode2")
assert(conf.get(KERBEROS_FILESYSTEMS_TO_ACCESS) === Array("testNode2"))

conf.set("spark.yarn.access.namenodes", "testNode3")
assert(conf.get(KERBEROS_FILESYSTEMS_TO_ACCESS) === Array("testNode2"))
}

test("akka deprecated configs") {
Expand Down