[SPARK-38918][SQL][3.1] Nested column pruning should filter out attributes that do not belong to the current relation #36387
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… that do not belong to the current relation This PR updates `ProjectionOverSchema` to use the outputs of the data source relation to filter the attributes in the nested schema pruning. This is needed because the attributes in the schema do not necessarily belong to the current data source relation. For example, if a filter contains a correlated subquery, then the subquery's children can contain attributes from both the inner query and the outer query. Since the `RewriteSubquery` batch happens after early scan pushdown rules, nested schema pruning can wrongly use the inner query's attributes to prune the outer query data schema, thus causing wrong results and unexpected exceptions. To fix a bug in `SchemaPruning`. No Unit test Closes apache#36216 from allisonwang-db/spark-38918-nested-column-pruning. Authored-by: allisonwang-db <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]> (cherry picked from commit 150434b) Signed-off-by: Liang-Chi Hsieh <[email protected]> (cherry picked from commit 793ba60) Signed-off-by: allisonwang-db <[email protected]>
Member
|
Seems related test failure? |
viirya
reviewed
Apr 28, 2022
| checkScan(query, | ||
| "struct<name:struct<first:string,middle:string,last:string>," + | ||
| "employer:struct<id:int,company:struct<name:string,address:string>>>", | ||
| "struct<name:struct<first:string>,employer:struct<company:struct<name:string>>>", |
Member
There was a problem hiding this comment.
Hmm, pruned schema is different in 3.1?
Contributor
Author
There was a problem hiding this comment.
Yes looks like starting from 3.2 it failed to prune some nested fields (for example in this case name.middle and name.last are not used)
Member
There was a problem hiding this comment.
Hmm, okay, but I think it is unrelated to this change.
viirya
approved these changes
Apr 28, 2022
Member
|
Thanks. Merging to branch-3.1. |
viirya
pushed a commit
that referenced
this pull request
Apr 28, 2022
…butes that do not belong to the current relation ### What changes were proposed in this pull request? Backport #36216 to branch-3.1. ### Why are the changes needed? To fix a bug in `SchemaPruning`. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Unit test Closes #36387 from allisonwang-db/spark-38918-branch-3.1. Authored-by: allisonwang-db <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Backport #36216 to branch-3.1.
Why are the changes needed?
To fix a bug in
SchemaPruning.Does this PR introduce any user-facing change?
No
How was this patch tested?
Unit test