[SPARK-34079][SQL][FOLLOW-UP] Revert some changes in InjectRuntimeFilterSuite #36361
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-toth
changed the title
Contributor
Author
|
cc @cloud-fan |
cloud-fan
reviewed
Apr 26, 2022
| 1 | ||
| val numBloomFilterAggs = plan.collect { | ||
| case Filter(condition, _) => condition.collect { | ||
| case subquery: org.apache.spark.sql.catalyst.expressions.ScalarSubquery |
Contributor
There was a problem hiding this comment.
I like the previous code more as it precisely matches Filter and ScalarSubquery. +1 to this change.
My major concern is scalarSubqueryCTEMultiplicator. This makes the test really hard to write as we need to manually think about if scalar subqueries merging can be applied or not to the testing query.
Can we turn off this optimization completely in this test suite? We can add one more test to verify the case that scalar subqueries merging is beneficial to bloom filter join, by explicitly enabling the optimizer rule.
Contributor
Author
There was a problem hiding this comment.
Got it, let me check...
Contributor
Author
cloud-fan
approved these changes
Apr 27, 2022
Contributor
|
thanks, merging to master/3.3! |
cloud-fan
pushed a commit
that referenced
this pull request
Apr 27, 2022
…terSuite To remove unnecessary changes from `InjectRuntimeFilterSuite` after #32298. These are not needed after #34929 as the final optimized plan does'n contain any `WithCTE` nodes. No need for those changes. No. Added new test. Closes #36361 from peter-toth/SPARK-34079-multi-column-scalar-subquery-follow-up-2. Authored-by: Peter Toth <[email protected]> Signed-off-by: Wenchen Fan <[email protected]> (cherry picked from commit d05e01d) Signed-off-by: Wenchen Fan <[email protected]>
Contributor
Author
|
Thanks @cloud-fan for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
To remove unnecessary changes from
InjectRuntimeFilterSuiteafter #32298. These are not needed after #34929 as the final optimized plan does'n contain anyWithCTEnodes.Why are the changes needed?
No need for those changes.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Added new test.