[SPARK-38786][SQL][TEST] Bug in StatisticsSuite 'change stats after add/drop partition command' #36075
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd/drop partition command'
Contributor
Author
sunchao
approved these changes
Apr 5, 2022
Member
sunchao
left a comment
sunchao
left a comment
There was a problem hiding this comment.
LGTM, thanks @kazuyukitanimura !
huaxingao
approved these changes
Apr 6, 2022
Member
|
Committed to master, thanks. |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 9, 2022
…dd/drop partition command' ### What changes were proposed in this pull request? https://github.com/apache/spark/blob/cbffc12f90e45d33e651e38cf886d7ab4bcf96da/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala#L979 It should be `partDir2` instead of `partDir1`. Looks like it is a copy paste bug. ### Why are the changes needed? Due to this test bug, the drop command was dropping a wrong (`partDir1`) underlying file in the test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added extra underlying file location check. Closes #36075 from kazuyukitanimura/SPARK-38786. Authored-by: Kazuyuki Tanimura <[email protected]> Signed-off-by: Chao Sun <[email protected]> (cherry picked from commit a6b04f0) Signed-off-by: Dongjoon Hyun <[email protected]>
Member
|
Thank you, @kazuyukitanimura , @sunchao , @huaxingao . Since the original bug was introduced at SPARK-33770 and was backported to old branches, I'll test and backport this to branch-3.3/3.2/3.1 too. |
Member
|
cc @MaxGekk |
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 9, 2022
…dd/drop partition command' ### What changes were proposed in this pull request? https://github.com/apache/spark/blob/cbffc12f90e45d33e651e38cf886d7ab4bcf96da/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala#L979 It should be `partDir2` instead of `partDir1`. Looks like it is a copy paste bug. ### Why are the changes needed? Due to this test bug, the drop command was dropping a wrong (`partDir1`) underlying file in the test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added extra underlying file location check. Closes #36075 from kazuyukitanimura/SPARK-38786. Authored-by: Kazuyuki Tanimura <[email protected]> Signed-off-by: Chao Sun <[email protected]> (cherry picked from commit a6b04f0) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a52a245) Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
pushed a commit
that referenced
this pull request
May 9, 2022
…dd/drop partition command' ### What changes were proposed in this pull request? https://github.com/apache/spark/blob/cbffc12f90e45d33e651e38cf886d7ab4bcf96da/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala#L979 It should be `partDir2` instead of `partDir1`. Looks like it is a copy paste bug. ### Why are the changes needed? Due to this test bug, the drop command was dropping a wrong (`partDir1`) underlying file in the test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added extra underlying file location check. Closes #36075 from kazuyukitanimura/SPARK-38786. Authored-by: Kazuyuki Tanimura <[email protected]> Signed-off-by: Chao Sun <[email protected]> (cherry picked from commit a6b04f0) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit a52a245) Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 04161ac) Signed-off-by: Dongjoon Hyun <[email protected]>
kazuyukitanimura
added a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
…dd/drop partition command' (apache#1385) ### What changes were proposed in this pull request? https://github.com/apache/spark/blob/cbffc12f90e45d33e651e38cf886d7ab4bcf96da/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala#L979 It should be `partDir2` instead of `partDir1`. Looks like it is a copy paste bug. ### Why are the changes needed? Due to this test bug, the drop command was dropping a wrong (`partDir1`) underlying file in the test. ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Added extra underlying file location check. Closes apache#36075 from kazuyukitanimura/SPARK-38786. Authored-by: Kazuyuki Tanimura <[email protected]> Signed-off-by: Chao Sun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
spark/sql/hive/src/test/scala/org/apache/spark/sql/hive/StatisticsSuite.scala
Line 979 in cbffc12
It should be
partDir2instead ofpartDir1. Looks like it is a copy paste bug.Why are the changes needed?
Due to this test bug, the drop command was dropping a wrong (
partDir1) underlying file in the test.Does this PR introduce any user-facing change?
No
How was this patch tested?
Added extra underlying file location check.