Skip to content

[SPARK-38770][K8S] Remove renameMainAppResource from baseDriverContainer #36044

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-38770][K8S] Remove renameMainAppResource from baseDriverContainer #36044

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5ad230
[SPARK-38770][K8S] Simply steps to re write primary resource in k8s s…
dcoliversun Apr 2, 2022
7dd1d05
address comments
dcoliversun Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions ...s/core/src/main/scala/org/apache/spark/deploy/k8s/features/DriverCommandFeatureStep.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,12 +120,6 @@ private[spark] class DriverCommandFeatureStep(conf: KubernetesDriverConf)
}

private def baseDriverContainer(pod: SparkPod, resource: String): ContainerBuilder = {
// re-write primary resource, app jar is also added to spark.jars by default in SparkSubmit
val resolvedResource = if (conf.mainAppResource.isInstanceOf[JavaMainAppResource]) {
KubernetesUtils.renameMainAppResource(resource, Option(conf.sparkConf), false)
} else {
resource
}
var proxyUserArgs = Seq[String]()
if (!conf.proxyUser.isEmpty) {
proxyUserArgs = proxyUserArgs :+ "--proxy-user"
Expand All @@ -136,7 +130,7 @@ private[spark] class DriverCommandFeatureStep(conf: KubernetesDriverConf)
.addToArgs(proxyUserArgs: _*)
.addToArgs("--properties-file", SPARK_CONF_PATH)
.addToArgs("--class", conf.mainClass)
.addToArgs(resolvedResource)
.addToArgs(resource)
.addToArgs(conf.appArgs: _*)
}
}