Skip to content

Conversation

@HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR proposes to add SparkContext.addArchive in PySpark side that's added in #30486.

Why are the changes needed?

To have the same API parity with the Scala side.

Does this PR introduce any user-facing change?

Yes, this PR exposes an API (SparkContext.addArchive) that exists in Scala side.

How was this patch tested?

Doctest was added.

@HyukjinKwon
Copy link
Member Author

cc @sarutak mind taking a look when you find some time?

@sarutak
Copy link
Member

sarutak commented Feb 22, 2022

@HyukjinKwon Thank you for adding this feature for Python!
I think it almost LGTM except for some minor stuffs.

Copy link
Member

@sarutak sarutak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Pending GA.

@sarutak
Copy link
Member

sarutak commented Feb 22, 2022

Merging to master. Thank you @HyukjinKwon and @Yikun !

@sarutak sarutak closed this in 48b56c0 Feb 22, 2022
@HyukjinKwon
Copy link
Member Author

Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants