[SPARK-38124][SS][FOLLOWUP] Add test to harden assumption of SS partitioning requirement #35529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c21
commented
Feb 15, 2022
| case x => fail(s"Unexpected partitionIdExpression $x for $hashPartitioning") | ||
| } | ||
|
|
||
| // Validate only HashPartitioning (and HashPartitioning in PartitioningCollection) can satisfy |
Contributor
Author
There was a problem hiding this comment.
Covered all subclasses of Partitioning here, except DataSourcePartitioning, because DataSourcePartitioning is not accessible from this unit test.
Contributor
Author
|
cc @cloud-fan, @sunchao, @viirya, @HyukjinKwon and @HeartSaVioR, thanks. |
HeartSaVioR
approved these changes
Feb 15, 2022
Contributor
HeartSaVioR
left a comment
HeartSaVioR
left a comment
There was a problem hiding this comment.
+1 Thanks for the addition of new test!
Contributor
|
Thanks! Merging to master. |
Contributor
Author
|
Thank you all for review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a followup of #35419 (comment), to add unit test to harden the assumption of SS partitioning and distribution requirement:
HashPartitioning.partitionIdExpressionto be exactly expected formatPartitioningagainstStatefulOpClusteredDistribution.Also add a minor comment for
StatefulOpClusteredDistribution, asSinglePartitioncan also satisfy the distribution.Why are the changes needed?
Document our assumption of SS in code as unit test.
So next time when we introduce intrusive code change, the unit test can save us by failing loudly.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
The added unit test itself.