Skip to content

[SPARK-38185][SQL] Fix data incorrect if aggregate function is empty #35490

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-38185][SQL] Fix data incorrect if aggregate function is empty #35490

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5900cce
Fix data incorrect if aggregate function is empty
ulysses-you Feb 11, 2022
b9e44c0
check grouping
ulysses-you Feb 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...st/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -984,7 +984,9 @@ case class Aggregate(

// Whether this Aggregate operator is group only. For example: SELECT a, a FROM t GROUP BY a
private[sql] def groupOnly: Boolean = {
aggregateExpressions.map {
// aggregateExpressions can be empty through Dateset.agg,
// so we should also check groupingExpressions is non empty
groupingExpressions.nonEmpty && aggregateExpressions.map {
case Alias(child, _) => child
case e => e
}.forall(a => groupingExpressions.exists(g => a.semanticEquals(g)))
Expand Down
5 changes: 5 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/DataFrameAggregateSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1443,6 +1443,11 @@ class DataFrameAggregateSuite extends QueryTest
val res = df.select($"d".cast("decimal(12, 2)").as("d")).agg(avg($"d").cast("string"))
checkAnswer(res, Row("9999999999.990000"))
}

test("SPARK-38185: Fix data incorrect if aggregate function is empty") {
val emptyAgg = Map.empty[String, String]
assert(spark.range(2).where("id > 2").agg(emptyAgg).limit(1).count == 1)
}
}

case class B(c: Option[Double])
Expand Down