[SPARK-38045][SS][TEST][3.2] More strict validation on plan check for stream-stream join unit test #35347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…am-stream join unit test This PR is a follow-up of SPARK-35693 to enhance the unit test on stream-stream join to be more strict on plan check. We would like to be more strict on plan check so that requirement of distribution against stream-stream join is fulfilled. No, test only. Modified test passed. Closes apache#35341 from HeartSaVioR/SPARK-35693-followup. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]>
dongjoon-hyun
approved these changes
Jan 28, 2022
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM (if CI tests pass). Thanks!
HyukjinKwon
approved these changes
Jan 28, 2022
Contributor
Author
|
Thanks! Merging to 3.2. |
HeartSaVioR
added a commit
that referenced
this pull request
Jan 28, 2022
… stream-stream join unit test ### What changes were proposed in this pull request? This PR is a follow-up of SPARK-35693 to enhance the unit test on stream-stream join to be more strict on plan check. ### Why are the changes needed? We would like to be more strict on plan check so that requirement of distribution against stream-stream join is fulfilled. ### Does this PR introduce _any_ user-facing change? No, test only. ### How was this patch tested? Modified test passed. Closes #35347 from HeartSaVioR/SPARK-38045-branch-3.2. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Contributor
Author
|
Addressed via 89a988c |
kazuyukitanimura
pushed a commit
to kazuyukitanimura/spark
that referenced
this pull request
Aug 10, 2022
… stream-stream join unit test ### What changes were proposed in this pull request? This PR is a follow-up of SPARK-35693 to enhance the unit test on stream-stream join to be more strict on plan check. ### Why are the changes needed? We would like to be more strict on plan check so that requirement of distribution against stream-stream join is fulfilled. ### Does this PR introduce _any_ user-facing change? No, test only. ### How was this patch tested? Modified test passed. Closes apache#35347 from HeartSaVioR/SPARK-38045-branch-3.2. Authored-by: Jungtaek Lim <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is a follow-up of SPARK-35693 to enhance the unit test on stream-stream join to be more strict on plan check.
Why are the changes needed?
We would like to be more strict on plan check so that requirement of distribution against stream-stream join is fulfilled.
Does this PR introduce any user-facing change?
No, test only.
How was this patch tested?
Modified test passed.