Skip to content

[SPARK-37984][SHUFFLE] Avoid calculating all outstanding requests to improve performance. #35276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[SPARK-37984][SHUFFLE] Avoid calculating all outstanding requests to improve performance. #35276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a8ff5
[SPARK-37984][SHUFFLE] Avoid calculating all outstanding requests to …
weixiuli Jan 22, 2022
cfba2db
Address comments
weixiuli Jan 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions ...etwork-common/src/main/java/org/apache/spark/network/client/TransportResponseHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ public void channelActive() {

@Override
public void channelInactive() {
if (numOutstandingRequests() > 0) {
if (hasOutstandingRequests()) {
String remoteAddress = getRemoteAddress(channel);
logger.error("Still have {} requests outstanding when connection from {} is closed",
numOutstandingRequests(), remoteAddress);
Expand All @@ -150,7 +150,7 @@ public void channelInactive() {

@Override
public void exceptionCaught(Throwable cause) {
if (numOutstandingRequests() > 0) {
if (hasOutstandingRequests()) {
String remoteAddress = getRemoteAddress(channel);
logger.error("Still have {} requests outstanding when connection from {} is closed",
numOutstandingRequests(), remoteAddress);
Expand Down Expand Up @@ -275,6 +275,12 @@ public int numOutstandingRequests() {
(streamActive ? 1 : 0);
}

/** Check if there are any outstanding requests (fetch requests + rpcs) */
public Boolean hasOutstandingRequests() {
return streamActive || !outstandingFetches.isEmpty() || !outstandingRpcs.isEmpty() ||
!streamCallbacks.isEmpty();
}

/** Returns the time in nanoseconds of when the last request was sent out. */
public long getTimeOfLastRequestNs() {
return timeOfLastRequestNs.get();
Expand Down
3 changes: 1 addition & 2 deletions ...network-common/src/main/java/org/apache/spark/network/server/TransportChannelHandler.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,8 +161,7 @@ public void userEventTriggered(ChannelHandlerContext ctx, Object evt) throws Exc
boolean isActuallyOverdue =
System.nanoTime() - responseHandler.getTimeOfLastRequestNs() > requestTimeoutNs;
if (e.state() == IdleState.ALL_IDLE && isActuallyOverdue) {
boolean hasInFlightRequests = responseHandler.numOutstandingRequests() > 0;
if (hasInFlightRequests) {
if (responseHandler.hasOutstandingRequests()) {
String address = getRemoteAddress(ctx.channel());
logger.error("Connection to {} has been quiet for {} ms while there are outstanding " +
"requests. Assuming connection is dead; please adjust" +
Expand Down