[SPARK-37446][SQL] Use reflection for getWithoutRegisterFns to allow different Hive versions for building #34690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Test build #145542 has finished for PR 34690 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Kubernetes integration test starting |
|
Test build #145543 has finished for PR 34690 at commit
|
|
Kubernetes integration test status failure |
HyukjinKwon
changed the title
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Nov 24, 2021
Member
HyukjinKwon
left a comment
HyukjinKwon
left a comment
There was a problem hiding this comment.
@AngersZhuuuu, how did you test this? Can you share the command for build, and show that the build succeeded?
Contributor
Author
With command Jars under dist I make this change since many user will build spark with it's own hive code and their own jar (they may do some optimize or. other thing in their own code). This pr make it easier to integrate and won't hurt current logic. |
HyukjinKwon
approved these changes
Nov 24, 2021
Member
|
Let's fill up "How was this patch tested?" in the PR description. |
Contributor
Author
Updated desc |
Member
|
Merged to master and branch-3.2. |
HyukjinKwon
pushed a commit
that referenced
this pull request
Nov 25, 2021
…different Hive versions for building ### What changes were proposed in this pull request? Since Hive 2.3.9 start have function `getWithoutRegisterFns`, but user may use hive 2.3.8 or lower version. Here we should use reflection to let user build with hive 2.3.8 or lower version ### Why are the changes needed? Support build with hive version lower than 2.3.9 since many user will build spark with it 's own hive code and their own jar (they may do some optimize or. other thing in their own code). This pr make it easier to integrate and won't hurt current logic. ### Does this PR introduce _any_ user-facing change? User can build spark with hive version lower than 2.3.9 ### How was this patch tested? build with command ``` ./dev/make-distribution.sh --tgz -Pyarn -Phive -Phive-thriftserver -Dhive.version=2.3.8 ``` Jars under dist  Closes #34690 from AngersZhuuuu/SPARK-37446. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 04671bd) Signed-off-by: Hyukjin Kwon <[email protected]>
sunchao
pushed a commit
to sunchao/spark
that referenced
this pull request
Dec 8, 2021
…different Hive versions for building ### What changes were proposed in this pull request? Since Hive 2.3.9 start have function `getWithoutRegisterFns`, but user may use hive 2.3.8 or lower version. Here we should use reflection to let user build with hive 2.3.8 or lower version ### Why are the changes needed? Support build with hive version lower than 2.3.9 since many user will build spark with it 's own hive code and their own jar (they may do some optimize or. other thing in their own code). This pr make it easier to integrate and won't hurt current logic. ### Does this PR introduce _any_ user-facing change? User can build spark with hive version lower than 2.3.9 ### How was this patch tested? build with command ``` ./dev/make-distribution.sh --tgz -Pyarn -Phive -Phive-thriftserver -Dhive.version=2.3.8 ``` Jars under dist  Closes apache#34690 from AngersZhuuuu/SPARK-37446. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 04671bd) Signed-off-by: Hyukjin Kwon <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Feb 22, 2022
…different Hive versions for building ### What changes were proposed in this pull request? Since Hive 2.3.9 start have function `getWithoutRegisterFns`, but user may use hive 2.3.8 or lower version. Here we should use reflection to let user build with hive 2.3.8 or lower version ### Why are the changes needed? Support build with hive version lower than 2.3.9 since many user will build spark with it 's own hive code and their own jar (they may do some optimize or. other thing in their own code). This pr make it easier to integrate and won't hurt current logic. ### Does this PR introduce _any_ user-facing change? User can build spark with hive version lower than 2.3.9 ### How was this patch tested? build with command ``` ./dev/make-distribution.sh --tgz -Pyarn -Phive -Phive-thriftserver -Dhive.version=2.3.8 ``` Jars under dist  Closes apache#34690 from AngersZhuuuu/SPARK-37446. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 04671bd) Signed-off-by: Hyukjin Kwon <[email protected]>
catalinii
pushed a commit
to lyft/spark
that referenced
this pull request
Mar 4, 2022
…different Hive versions for building ### What changes were proposed in this pull request? Since Hive 2.3.9 start have function `getWithoutRegisterFns`, but user may use hive 2.3.8 or lower version. Here we should use reflection to let user build with hive 2.3.8 or lower version ### Why are the changes needed? Support build with hive version lower than 2.3.9 since many user will build spark with it 's own hive code and their own jar (they may do some optimize or. other thing in their own code). This pr make it easier to integrate and won't hurt current logic. ### Does this PR introduce _any_ user-facing change? User can build spark with hive version lower than 2.3.9 ### How was this patch tested? build with command ``` ./dev/make-distribution.sh --tgz -Pyarn -Phive -Phive-thriftserver -Dhive.version=2.3.8 ``` Jars under dist  Closes apache#34690 from AngersZhuuuu/SPARK-37446. Authored-by: Angerszhuuuu <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]> (cherry picked from commit 04671bd) Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Since Hive 2.3.9 start have function
getWithoutRegisterFns, but user may use hive 2.3.8 or lower version.Here we should use reflection to let user build with hive 2.3.8 or lower version
Why are the changes needed?
Support build with hive version lower than 2.3.9 since many user will build spark with it 's own hive code and their own jar (they may do some optimize or. other thing in their own code). This pr make it easier to integrate and won't hurt current logic.
Does this PR introduce any user-facing change?
User can build spark with hive version lower than 2.3.9
How was this patch tested?
build with command
Jars under dist
