[SPARK-37368][SQL][TESTS] Explicit GC for TPC-DS query runs #34641
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
requested review from
cloud-fan,
dongjoon-hyun and
maropu
and removed request for
maropu
dongjoon-hyun
approved these changes
Nov 18, 2021
Member
Author
|
Yeah .. this is hacky and ugly workaround .. so I haven't pushed to OSS so far but .. at least it works .. |
cloud-fan
approved these changes
Nov 18, 2021
|
Kubernetes integration test starting |
Member
Author
|
Merged to master. Let's see how it gose. |
|
Kubernetes integration test status failure |
|
Test build #145365 has finished for PR 34641 at commit
|
HyukjinKwon
added a commit
that referenced
this pull request
Nov 25, 2021
### What changes were proposed in this pull request? This is kind of a followup for #33510 and #34641. This PR proposes to split TPC-DS build in GitHub Actions. ### Why are the changes needed? Running these queries easily causes out-of-memory in GitHub Actions machines, and make the build flaky. We should deflake it. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? GitHub Actions in this PR should test it out. Closes #34698 from HyukjinKwon/split-tpcds. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to explicitly GC between each query of TPC-DS.
Why are the changes needed?
Due to the lack of memory in GitHub Actions machines, they easily die in the middle of testing. This is rather a bandaid workaround.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
It has been tested in the fork of Spark in the company I work for.