Skip to content

[SPARK-37341][SQL] Avoid unnecessary buffer and copy in full outer sort merge join #34612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[SPARK-37341][SQL] Avoid unnecessary buffer and copy in full outer sort merge join #34612

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/joins/SortMergeJoinExec.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1631,15 +1631,19 @@ private class SortMergeFullOuterJoinScanner(
advancedRight()
true
} else if (leftRow != null && rightRow != null) {
// Both rows are present and neither have null values,
// so we populate the buffers with rows matching the next key
// Both rows are present and neither have null values.
val comp = keyOrdering.compare(leftRowKey, rightRowKey)
if (comp <= 0) {
findMatchingRows(leftRowKey.copy())
if (comp < 0) {
joinedRow(leftRow.copy(), rightNullRow)
advancedLeft()
} else if (comp > 0) {
joinedRow(leftNullRow, rightRow.copy())
advancedRight()
} else {
findMatchingRows(rightRowKey.copy())
// Populate the buffers with rows matching the next key.
findMatchingRows(leftRowKey.copy())
scanNextInBuffered()
}
scanNextInBuffered()
true
} else {
// Both iterators have been consumed
Expand Down