Skip to content

Conversation

@nchammas
Copy link
Contributor

What changes were proposed in this pull request?

Some of the columns included in the DataFrames returned by FPGrowthModel are not explained. This PR adds some basic documentation for them. Since those docs depend on the concept of an itemset, this PR also introduces that term.

Why are the changes needed?

The FPGrowth docs should cover at a high level all the basic information that the algorithm provides.

Does this PR introduce any user-facing change?

Yes, it updates user-facing documentation.

How was this patch tested?

I will confirm the doc changes are correct as part of PR review.

@github-actions github-actions bot added the DOCS label Nov 15, 2021
@nchammas
Copy link
Contributor Author

cc @srowen since you also reviewed #22236.

(I don't mean to imply "you touch it, you own it"; I'm just not sure who else would know/care about FPGrowth. 😄)

@SparkQA
Copy link

SparkQA commented Nov 15, 2021

Test build #145245 has finished for PR 34605 at commit e349eb4.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@SparkQA
Copy link

SparkQA commented Nov 15, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49715/

@SparkQA
Copy link

SparkQA commented Nov 15, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/49715/

@srowen
Copy link
Member

srowen commented Nov 16, 2021

Merged to master

@srowen srowen closed this in ff2608c Nov 16, 2021
@nchammas nchammas deleted the SPARK-37335-fpgrowth-docs branch November 16, 2021 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants