Skip to content

[SPARK-4606] Send EOF to child JVM when there's no more data to read. #3460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[SPARK-4606] Send EOF to child JVM when there's no more data to read. #3460

wants to merge 1 commit into from

Conversation

@vanzin
Copy link
Contributor

@vanzin vanzin commented Nov 25, 2014

No description provided.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23846 has started for PR 3460 at commit 031207d.

  • This patch merges cleanly.

@SparkQA
Copy link

SparkQA commented Nov 25, 2014

Test build #23846 has finished for PR 3460 at commit 031207d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@AmplabJenkins
Copy link

AmplabJenkins commented Nov 25, 2014

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/23846/
Test PASSed.

JoshRosen
JoshRosen reviewed Dec 23, 2014
View reviewed changes
core/src/main/scala/org/apache/spark/deploy/SparkSubmitDriverBootstrapper.scala
Copy link
Contributor

@JoshRosen JoshRosen Dec 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kind of nitpicky, but I'd probably explicitly name the boolean parameter here (IntelliJ complains otherwise, and besides, it's a nice practice). I can fix this up myself on merge, though.

@JoshRosen
Copy link
Contributor

JoshRosen commented Dec 23, 2014

I tried this out and was able to reproduce the original issue based on your JIRA description, and I can confirm that this PR fixes the problem. It looks like this issue also affects 1.1.1, so I'll pull this in there, too.

Therefore, I'm going to merge this into master (1.3.0), branch-1.2 (1.2.1), and branch-1.1 (1.1.2).

asfgit pushed a commit that referenced this pull request Dec 24, 2014
@JoshRosen
[SPARK-4606] Send EOF to child JVM when there's no more data to read.
1a4e2ba 
Author: Marcelo Vanzin <[email protected]>

Closes #3460 from vanzin/SPARK-4606 and squashes the following commits:

031207d [Marcelo Vanzin] [SPARK-4606] Send EOF to child JVM when there's no more data to read.

(cherry picked from commit 7e2deb7)
Signed-off-by: Josh Rosen <[email protected]>
@asfgit asfgit closed this in 7e2deb7 Dec 24, 2014
asfgit pushed a commit that referenced this pull request Dec 24, 2014
@JoshRosen
[SPARK-4606] Send EOF to child JVM when there's no more data to read.
dd0287c 
Author: Marcelo Vanzin <[email protected]>

Closes #3460 from vanzin/SPARK-4606 and squashes the following commits:

031207d [Marcelo Vanzin] [SPARK-4606] Send EOF to child JVM when there's no more data to read.

(cherry picked from commit 7e2deb7)
Signed-off-by: Josh Rosen <[email protected]>
@vanzin vanzin deleted the SPARK-4606 branch December 24, 2014 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@vanzin @SparkQA @AmplabJenkins @JoshRosen