[SPARK-37080][INFRA] Add benchmark tool guide in pull request template #34349
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
HyukjinKwon
reviewed
Oct 21, 2021
| If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible. | ||
| If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future. | ||
| If tests were not added, please describe why they were not added and/or why it was difficult to add. | ||
| If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. |
Member
There was a problem hiding this comment.
Suggested change
| If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. | |
| If benchmark tests were added, please run the benchmarks via GitHub Actions, see also https://spark.apache.org/developer-tools.html#github-workflow-benchmarks. |
Member
There was a problem hiding this comment.
I actually documented this in https://spark.apache.org/contributing.html but mentioning here again is fine as one of the key points you should know.
HyukjinKwon
approved these changes
Oct 21, 2021
Member
|
Merged to master (since the tests don't cover this change in any event). |
|
Kubernetes integration test starting |
Contributor
Author
|
thank you @HyukjinKwon |
|
Kubernetes integration test status failure |
|
Test build #144482 has finished for PR 34349 at commit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add benchmark tool guide in pull request template
Why are the changes needed?
Add benchmark tool guide in pull request template to help developers find it.
Does this PR introduce any user-facing change?
yes, pr template changed
How was this patch tested?
not needed