Skip to content

Conversation

@cloud-fan
Copy link
Contributor

What changes were proposed in this pull request?

When checking unresolved attributes, we should check Aggregate.aggregateExpressions before Aggregate.groupingExpressions, because the latter may rely on the former, due to the GROUP BY alias feature.

Why are the changes needed?

improve error message

Does this PR introduce any user-facing change?

no

How was this patch tested?

new test

@github-actions github-actions bot added the SQL label Oct 11, 2021
@cloud-fan
Copy link
Contributor Author

cloud-fan commented Oct 11, 2021

cc @viirya @maropu

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48567/

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Test build #144089 has finished for PR 34244 at commit fec2d84.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@viirya
Copy link
Member

viirya commented Oct 11, 2021

retest this please

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48577/

@SparkQA
Copy link

SparkQA commented Oct 11, 2021

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48577/

@SparkQA
Copy link

SparkQA commented Oct 12, 2021

Test build #144099 has finished for PR 34244 at commit fec2d84.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@cloud-fan
Copy link
Contributor Author

thanks for the review, merging to master!

@cloud-fan cloud-fan closed this in dc1db95 Oct 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants