[SPARK-36177][R][TESTS][3.0] Disable CRAN in branches lower than the latest version uploaded #33390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HyukjinKwon
changed the title
MaxGekk
approved these changes
Jul 16, 2021
gengliangwang
approved these changes
Jul 16, 2021
|
Test build #141150 has finished for PR 33390 at commit
|
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
|
Test build #141156 has finished for PR 33390 at commit
|
HyukjinKwon
added a commit
that referenced
this pull request
Jul 16, 2021
…latest version uploaded ### What changes were proposed in this pull request? This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN) ### Why are the changes needed? Same as #33390. Spark 3.2.0 will very likely come first before Spark 3.1.x. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? It will be tested in the CI at this PR. Closes #33391 from HyukjinKwon/SPARK-36177. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Member
Author
|
Merged to branch-3.0. |
HyukjinKwon
added a commit
that referenced
this pull request
Jul 16, 2021
…latest version uploaded ### What changes were proposed in this pull request? This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN) ### Why are the changes needed? CRAN check in branch-3.0 fails as below: ``` Insufficient package version (submitted: 3.0.4, existing: 3.1.2) ``` This is because CRAN doesn't allow lower version then the latest version. We can't upload so should better just skip the CRAN check. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? It will be tested in the CI at this PR. Closes #33390 from HyukjinKwon/sparkr-cran. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
|
Kubernetes integration test starting |
|
Kubernetes integration test status failure |
Member
|
+1, late LGTM. Thank you, @HyukjinKwon ! |
flyrain
pushed a commit
to flyrain/spark
that referenced
this pull request
Sep 21, 2021
…latest version uploaded ### What changes were proposed in this pull request? This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN) ### Why are the changes needed? Same as apache#33390. Spark 3.2.0 will very likely come first before Spark 3.1.x. ### Does this PR introduce _any_ user-facing change? No, dev-only. ### How was this patch tested? It will be tested in the CI at this PR. Closes apache#33391 from HyukjinKwon/SPARK-36177. Authored-by: Hyukjin Kwon <[email protected]> Signed-off-by: Hyukjin Kwon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR proposes to skip the CRAN check in old branches (than the latest version uploaded to CRAN)
Why are the changes needed?
CRAN check in branch-3.0 fails as below:
This is because CRAN doesn't allow lower version then the latest version. We can't upload so should better just skip the CRAN check.
Does this PR introduce any user-facing change?
No, dev-only.
How was this patch tested?
It will be tested in the CI at this PR.