Skip to content

Conversation

@jerqi
Copy link
Contributor

@jerqi jerqi commented Jul 6, 2021

backport #33204 to 3.0

What changes were proposed in this pull request?

PR #15764 disabled creating permanent views based on temporary views or UDFs. But AlterViewCommand didn't block temporary objects.

Why are the changes needed?

More robust view canonicalization.

Does this PR introduce any user-facing change?

Yes, now if you alter a permanent view based on temporary views or UDFs, the operation will fail.

How was this patch tested?

Add new unit tests.

@jerqi jerqi force-pushed the backup_3.0_alter_view branch from 23f4ba0 to 7370a22 Compare July 6, 2021 15:41
@AmplabJenkins
Copy link

Can one of the admins verify this patch?

@jerqi jerqi force-pushed the backup_3.0_alter_view branch from 7370a22 to 54f3f70 Compare July 6, 2021 16:03
@HyukjinKwon
Copy link
Member

Same as #33230 (comment). I wouldn't backport either.

@jerqi jerqi closed this Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants