Skip to content

[SPARK-36011][SQL] Disallow altering permanent views based on temporary views or UDFs #33204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

[SPARK-36011][SQL] Disallow altering permanent views based on temporary views or UDFs #33204

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
54a2feb
[SPARK-36011][SQL] Disallow altering permanent views based on tempora…
Jul 4, 2021
66f498e
trigger test
Jul 5, 2021
24a57a7
address comments
Jul 6, 2021
ee5e76e
address comments
Jul 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions sql/core/src/main/scala/org/apache/spark/sql/execution/command/views.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,7 +259,10 @@ case class AlterViewAsCommand(
def markAsAnalyzed(): LogicalPlan = copy(isAnalyzed = true)

override def run(session: SparkSession): Seq[Row] = {
if (session.sessionState.catalog.isTempView(name)) {
val isTemporary = session.sessionState.catalog.isTempView(name)
verifyTemporaryObjectsNotExists(session.sessionState.catalog, isTemporary, name, query)
verifyAutoGeneratedAliasesNotExists(query, isTemporary, name)
if (isTemporary) {
alterTemporaryView(session, query)
} else {
alterPermanentView(session, query)
Expand All @@ -286,7 +289,6 @@ case class AlterViewAsCommand(
}

private def alterPermanentView(session: SparkSession, analyzedPlan: LogicalPlan): Unit = {
verifyAutoGeneratedAliasesNotExists(analyzedPlan, isTemporary = false, name)
val viewMeta = session.sessionState.catalog.getTableMetadata(name)

// Detect cyclic view reference on ALTER VIEW.
Expand Down
28 changes: 28 additions & 0 deletions sql/core/src/test/scala/org/apache/spark/sql/execution/SQLViewTestSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -465,4 +465,32 @@ class PersistedViewTestSuite extends SQLViewTestSuite with SharedSparkSession {
}
}
}

test("SPARK-36011: Disallow altering permanent views based on temporary views or UDFs") {
import testImplicits._
withTable("t") {
(1 to 10).toDF("id").write.saveAsTable("t")
withView("v1") {
withTempView("v2") {
sql("CREATE VIEW v1 AS SELECT * FROM t")
sql("CREATE TEMPORARY VIEW v2 AS SELECT * FROM t")
var e = intercept[AnalysisException] {
sql("ALTER VIEW v1 AS SELECT * FROM v2")
}.getMessage
assert(e.contains("Not allowed to create a permanent view `default`.`v1` by " +
"referencing a temporary view v2"))
val tempFunctionName = "temp_udf"
val functionClass = "test.org.apache.spark.sql.MyDoubleAvg"
withUserDefinedFunction(tempFunctionName -> true) {
sql(s"CREATE TEMPORARY FUNCTION $tempFunctionName AS '$functionClass'")
e = intercept[AnalysisException] {
sql(s"ALTER VIEW v1 AS SELECT $tempFunctionName(id) from t")
}.getMessage
assert(e.contains("Not allowed to create a permanent view `default`.`v1` by " +
s"referencing a temporary function `$tempFunctionName`"))
}
}
}
}
}
}