[SPARK-35990][BUILD] Remove avro-sbt plugin dependency #33190
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Nice catch! +1, LGTM (if CI passes)
|
Kubernetes integration test unable to build dist. exiting with code: 1 |
|
Test build #140581 has finished for PR 33190 at commit
|
dongjoon-hyun
approved these changes
Jul 2, 2021
Member
dongjoon-hyun
left a comment
dongjoon-hyun
left a comment
There was a problem hiding this comment.
+1, LGTM. Merged to master/3.2 for the clean-up for Apache Spark 3.2.
dongjoon-hyun
pushed a commit
that referenced
this pull request
Jul 2, 2021
### What changes were proposed in this pull request? This PR removes sbt-avro plugin dependency. In the current master, Build with SBT depends on the plugin but it seems never used. Originally, the plugin was introduced for `flume-sink` in SPARK-1729 (#807) but `flume-sink` is no longer in Spark repository. After SBT was upgraded to 1.x in SPARK-21708 (#29286), `avroGenerate` part was introduced in `object SQL` in `SparkBuild.scala`. It's confusable but I understand `Test / avroGenerate := (Compile / avroGenerate).value` is for suppressing sbt-avro for `sql` sub-module. In fact, Test/compile will fail if `Test / avroGenerate :=(Compile / avroGenerate).value` is commented out. `sql` sub-module contains `parquet-compat.avpr` and `parquet-compat.avdl` but according to `sql/core/src/test/README.md`, they are intended to be handled by `gen-avro.sh`. Also, in terms of Maven build, there seems to be no definition to handle `*.avpr` or `*.avdl`. Based on the above, I think we can remove `sbt-avro`. ### Why are the changes needed? If `sbt-avro` is really no longer used, it's confusable that `sbt-avro` related configurations are in `SparkBuild.scala`. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? GA. Closes #33190 from sarutak/remove-avro-from-sbt. Authored-by: Kousuke Saruta <[email protected]> Signed-off-by: Dongjoon Hyun <[email protected]> (cherry picked from commit 6c4616b) Signed-off-by: Dongjoon Hyun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR removes sbt-avro plugin dependency.
In the current master, Build with SBT depends on the plugin but it seems never used.
Originally, the plugin was introduced for
flume-sinkin SPARK-1729 (#807) butflume-sinkis no longer in Spark repository.After SBT was upgraded to 1.x in SPARK-21708 (#29286),
avroGeneratepart was introduced inobject SQLinSparkBuild.scala.It's confusable but I understand
Test / avroGenerate := (Compile / avroGenerate).valueis for suppressing sbt-avro forsqlsub-module.In fact, Test/compile will fail if
Test / avroGenerate :=(Compile / avroGenerate).valueis commented out.sqlsub-module containsparquet-compat.avprandparquet-compat.avdlbut according tosql/core/src/test/README.md, they are intended to be handled bygen-avro.sh.Also, in terms of Maven build, there seems to be no definition to handle
*.avpror*.avdl.Based on the above, I think we can remove
sbt-avro.Why are the changes needed?
If
sbt-avrois really no longer used, it's confusable thatsbt-avrorelated configurations are inSparkBuild.scala.Does this PR introduce any user-facing change?
No.
How was this patch tested?
GA.