[SPARK-35785][SS][3.2] Cleanup support for RocksDB instance #33184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### What changes were proposed in this pull request? Add the functionality of cleaning up files of old versions for the RocksDB instance and RocksDBFileManager. ### Why are the changes needed? Part of the implementation of RocksDB state store. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New UT added. Closes apache#32933 from xuanyuanking/SPARK-35785. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Liang-Chi Hsieh <[email protected]>
Member
Author
|
cc @HeartSaVioR and @viirya |
HeartSaVioR
changed the title
HeartSaVioR
pushed a commit
that referenced
this pull request
Jul 2, 2021
### What changes were proposed in this pull request? Add the functionality of cleaning up files of old versions for the RocksDB instance and RocksDBFileManager. ### Why are the changes needed? Part of the implementation of RocksDB state store. ### Does this PR introduce _any_ user-facing change? No. ### How was this patch tested? New UT added. Closes #33184 from xuanyuanking/branch-3.2. Authored-by: Yuanjian Li <[email protected]> Signed-off-by: Jungtaek Lim <[email protected]>
Contributor
|
Merged to branch-3.2. |
Contributor
|
forgot my +1 . this is just a cherry-pick of #32933. |
Member
Author
|
Thanks @HeartSaVioR! |
Member
|
Thanks @xuanyuanking and @HeartSaVioR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add the functionality of cleaning up files of old versions for the RocksDB instance and RocksDBFileManager.
Why are the changes needed?
Part of the implementation of RocksDB state store.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
New UT added.